Fix #53 by removing python 2.7.6 from TravisCI builds#68
Fix #53 by removing python 2.7.6 from TravisCI builds#68seratch merged 2 commits intoslackapi:masterfrom
Conversation
|
After merging this PR, I will check the existing mergeable PRs. |
|
Ah, we need to repair the build settings first. I will work on it. |
seratch
changed the title
seratch
changed the title
| testfixtures==5.3.1 | ||
| tox==2.9.1 No newline at end of file | ||
| tox==2.9.1 | ||
| werkzeug==0.16.1 No newline at end of file |
There was a problem hiding this comment.
This is a quick (and tentative) fix for ImportError: cannot import name 'cached_property' from 'werkzeug' (incompatibility with werkzeug 1.0), which is not an issue of this library.
see also: jarus/flask-testing#143
There was a problem hiding this comment.
Is werkzeug a transitive dependency through some other dependency? I'm not sure how this affected our package.
There was a problem hiding this comment.
@aoberoi
Flask depends on werkzeug. Flask's project setting has been declaring it is compatible with Werkzeug>=0.15 for a long time.
As mentioned above (and also you can see the actual failure here), werkzeug 1.0 is incompatible with 0.16 or older as it has removed cached_property module.
As far as I know, the breaking change affects only tests with Flask. I haven't found any issues with production apps yet. I will verify if there is really no issue. I'm going to check which versions of Flask this package should support soon in regards to #58
On the assumption that the breaking change doesn't directly affect this package, I just applied a quick fix to run tests with werkzeug 0.16. In my observation, it's safe enough.
Does this make sense to you?
|
@stevengill @aoberoi This PR is ready for review. |
|
I'll merge this PR tomorrow. |
3 participants
Summary
This pull request fixed #53 by removing python 2.7.6 from CI builds.
Requirements (place an
xin each[ ])