Accept usage of Flask Blueprints as app instance#56
Accept usage of Flask Blueprints as app instance#56maryum375 wants to merge 2 commits intoslackapi:masterfrom
Conversation
|
This is something I came across as well which would be nice to merge. |
Co-authored-by: Matt Smith <psykzz@users.noreply.github.com>
|
@maryum375 Thank you very much for taking the time to make this pull request. Also, I'm sorry that the team took a very long time (almost one year) until checking it. I'm moving this forward. I've applied some additional changes to your PR in #69. It would be greatly appreciated if you check it and give us feedback if you have some. |
|
Any reason that needed to go into a new PR and couldn't have been added to this one? If not it would be good to add @maryum375 to the co-authors via |
Good point. Indeed, it's usually possible but somehow this repository seems to be a bit different. I've walked through the repository settings but haven't found any relevant settings to modify. So, I know it's not ideal but went with a new pull request.
Thanks, I didn't know this! I don't think we need to modify my PR a lot but I'll update my commits with this. Update: To be clear, my PR never removes @maryum375's original contribution as the commit's email hasn't been changed. |
Update #56 - Accept usage of Flask Blueprints as app instance
|
@maryum375 Thanks for your contribution here. I just shipped 2.2.0rc1, a pre-release version including a fix for this. Please try it out if you have a chance. v2.2.0 will be out soon. |

Summary
Allowing usage of slack blueprints to setup the SlackServer instance.
Requirements (place an
xin each[ ])