Skip to content

Change example bot to work with slackclient>=2.0.#51

Merged
seratch merged 1 commit intoslackapi:masterfrom
jeffFranklin:patch-1
Jun 11, 2020
Merged

Change example bot to work with slackclient>=2.0.#51
seratch merged 1 commit intoslackapi:masterfrom
jeffFranklin:patch-1

Conversation

@jeffFranklin
Copy link
Contributor

@jeffFranklin jeffFranklin commented May 7, 2019

Summary

Package slackclient 2.0 and beyond uses namespace slack in place of slackclient.
Use the equivalent slack.WebClient, and change the method call to use slack.WebClient.chat_postMessage. This is for the bot example code.

Requirements (place an x in each [ ])

@RodneyU215
Copy link

RodneyU215 commented May 7, 2019

Right on @jeffFranklin! Thank you for this PR. 🙇 Before we merge this, would you mind updating the ReadMe's Python requirements to reflect your changes as well. We'd just have to remove the lines about Python 2.7 since the new SDK only supports Python 3.6+.

@RodneyU215 RodneyU215 requested a review from Roach May 7, 2019 18:51
@jeffFranklin
Copy link
Contributor Author

jeffFranklin commented May 7, 2019

Thanks @RodneyU215! I've added a note about slackclient v2 to the README. I think python 3.6+ is the way to be, and it would simplify your documentation and make it even better. The part about virtualenv could go away, as it would get replaced with python3 -m venv env. I could make the change in my PR but I wouldn't want to muddle my initial change, plus your team might want to decide how to say it. Cheers!

Roach
Roach reviewed May 7, 2019
View reviewed changes
Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jeffFranklin! 🎉

@Roach Roach mentioned this pull request May 9, 2019
Closed
@jeffFranklin
Copy link
Contributor Author

jeffFranklin commented May 10, 2019

Should I change the readme to be python3-specific in this PR? I could. It wasn't clear if you wanted that as part of this change. Thanks.

@seratch
Copy link
Contributor

seratch commented Jun 11, 2020

@jeffFranklin Thanks for your contribution! I'm sorry for taking a long time to merge this.

@seratch seratch merged commit 055d905 into slackapi:master Jun 11, 2020
@seratch seratch mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Roach Roach Roach left review comments

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffFranklin @RodneyU215 @seratch @Roach