Merged
Conversation
Contributor
Author
|
Please notify me if/when the base PR is merged, and I'll rebase this on new master. |
datashaman
force-pushed
the
feature/test-error-event
branch
from
5b3c1e2 to
804e3b2
Compare
seratch
approved these changes
Jun 11, 2020
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
LGTM - thanks for your contribution and I'm sorry for our very slow response here.
Contributor
|
I've verified this change doesn't have any issues with the latest revision by merging and running tests on my local machine. It's safe enough to merge these tests and they're good addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that emitters for timestamp and signature errors are emitted correctly.
Requires (and is based on) #37