Ensure event handler is called in event test#37
Merged
seratch merged 1 commit intoslackapi:masterfrom Jun 11, 2020
Merged
Conversation
|
|
datashaman
force-pushed
the
hotfix/event-test
branch
from
0e3e0d8 to
c115c7b
Compare
2 tasks
Contributor
Author
|
I've just noticed this warning: Unsure if this is a big problem or not. I could just instantiate a different adapter within the app fixture. The tests should still pass. |
datashaman
force-pushed
the
hotfix/event-test
branch
from
c115c7b to
16961ab
Compare
seratch
approved these changes
Jun 11, 2020
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
LGTM - thanks for your contribution and I'm sorry for taking such a long time to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current event test does not go into the event handler. I added
assert 1 == 0inside it and the tests all passed.