Improve security by adding request signing#34
Merged
Conversation
shaydewael
suggested changes
Aug 8, 2018
README.rst
Outdated
|
|
||
|
|
||
| slack_events_adapter = SlackEventAdapter(SLACK_VERIFICATION_TOKEN, endpoint="/slack/events") | ||
| slack_events_adapter = SlackEventAdapter(SLACK_VERIFICATION_TOKEN, endpoint="/slack_events") |
Contributor
There was a problem hiding this comment.
hmm...why the move from /slack/events to slack_events?
| # Initialize the Slack event server | ||
| # If no endpoint is provided, default to listening on '/slack/events' | ||
| def __init__(self, verification_token, endpoint="/slack/events", server=None): | ||
| def __init__(self, signing_secret, endpoint="/slack/events", server=None, **kwargs): |
Contributor
There was a problem hiding this comment.
Is this **kwargs used now that we aren't using any optional flags?
slackeventsapi/server.py
Outdated
| # Each request comes with request timestamp and request signature | ||
| # emit an error if the timestamp is out of range | ||
| req_timestamp = request.headers.get('X-Slack-Request-Timestamp') | ||
| if abs(time() - int(req_timestamp)) > 60 * 10: |
Contributor
There was a problem hiding this comment.
Should this be 60 * 5? In the docs, we say to make sure the request is no longer than 5 mins (https://api.slack.com/docs/verifying-requests-from-slack#how_to_make_a_request_signature_in_4_easy_steps__an_overview)
slackeventsapi/server.py
Outdated
| req_timestamp = request.headers.get('X-Slack-Request-Timestamp') | ||
| if abs(time() - int(req_timestamp)) > 60 * 10: | ||
| self.emitter.emit('error', Exception('Request timestamp invalid')) | ||
| return make_response("", 200) |
Contributor
There was a problem hiding this comment.
500 or 404 status code instead of 200?
slackeventsapi/server.py
Outdated
| req_signature = request.headers.get('X-Slack-Signature') | ||
| if not self.verify_signature(req_timestamp, req_signature): | ||
| self.emitter.emit('error', Exception('invalid request signature')) | ||
| return make_response("", 200) |
slackeventsapi/server.py
Outdated
|
|
||
| # Echo the URL verification challenge code | ||
| # Echo the URL verification challenge code back to Slack | ||
| if "challenge" in event_data: |
Contributor
There was a problem hiding this comment.
It might make sense to move this to after the request signature verification, since we aren't verifying the token in the request body anymore.
aoberoi
suggested changes
Aug 8, 2018
example/README.rst
Outdated
| .. image:: https://cloud.githubusercontent.com/assets/32463/24877833/950dd53c-1de5-11e7-984f-deb26e8b9482.png | ||
|
|
||
| Add your app's **Verification Token** to your python environmental variables | ||
| Add your app's **Singing Secret** to your python environmental variables |
Contributor
There was a problem hiding this comment.
Spelling. Singing -> Signing.
Contributor
Author
There was a problem hiding this comment.
__
_ ,___,-'",-=-.
__,-- _ _,-'_)_ (""`'-._\ `.
_,' __ |,' ,-' __) ,- /. |
,'_,--' | -' _)/ `\
,',' ,' ,-'_,` :
,' ,-' ,(,-( :
,' ,-' , _ ;
/ ,-._/`---' /
/ (____)(----. ) ,'
/ ( `.__, /\ /,
: ;-.___ /__\/|
| ,' `--. -,\ |
: / \ .__/
\ (__ \ |_
\ ,`-, * / _|,\
\ ,' `-. ,'_,-' \
(_\,-' ,'\")--,'-' __\
\ / // ,'| ,--' `-.
`-. `-/ \' | _,' `.
`-._ / `--'/ \
,' | \
/ | \
,-' | /
/ | -'
Roach
commented
Aug 9, 2018
slackeventsapi/server.py
Outdated
| req_signature = request.headers.get('X-Slack-Signature') | ||
| if not self.verify_signature(req_timestamp, req_signature): | ||
| self.emitter.emit('error', Exception('invalid request signature')) | ||
| return make_response("", 200) |
shaydewael
approved these changes
Aug 9, 2018
aoberoi
reviewed
Aug 9, 2018
tests/test_server.py
Outdated
| } | ||
| ) | ||
|
|
||
| assert res.status_code == 404 |
aoberoi
suggested changes
Aug 9, 2018
slackeventsapi/server.py
Outdated
| # emit an error if the timestamp is out of range | ||
| req_timestamp = request.headers.get('X-Slack-Request-Timestamp') | ||
| if abs(time() - int(req_timestamp)) > 60 * 5: | ||
| slack_exception = Exception('Invalid request timestamp') |
slackeventsapi/server.py
Outdated
| # emit an error if the signature can't be verified | ||
| req_signature = request.headers.get('X-Slack-Signature') | ||
| if not self.verify_signature(req_timestamp, req_signature): | ||
| slack_exception = Exception('Invalid request signature') |
…ack-events-api into roach/request-signing
aoberoi
approved these changes
Aug 14, 2018
whitespace
…ack-events-api into roach/request-signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces request token verification with request signing.
See https://api.slack.com/docs/verifying-requests-from-slack for more info.
Fixes #33
Tests are still in progress.
Requirements (place an
xin each[ ])