create undocumented message bot events#1424
Open
bruceadowns wants to merge 9 commits intoslackapi:mainfrom
Open
create undocumented message bot events#1424bruceadowns wants to merge 9 commits intoslackapi:mainfrom
bruceadowns wants to merge 9 commits intoslackapi:mainfrom
Conversation
* message_bot_add * message_bot_remove * these occur on add/remove of incoming webhook
Author
|
@seratch I would like to add these 2 events to my bot, would you pls review. Also, I suspect you may want unit tests, if so pls give me an overview of what tests you’d like to see, and where they go. |
Contributor
|
Thanks for taking the time to send this pull request. Let me mention two points:
|
Author
|
Thank you @seratch, I reverted unrelated changes. I will mark this PR as ready and then wait until your team gets official word. Tests can be added at that time if you choose to go forward. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
============================================
- Coverage 73.20% 73.15% -0.06%
+ Complexity 4388 4387 -1
============================================
Files 475 475
Lines 14243 14243
Branches 1447 1447
============================================
- Hits 10427 10419 -8
- Misses 2959 2970 +11
+ Partials 857 854 -3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.