Skip to content
This repository was archived by the owner on Aug 15, 2022. It is now read-only.

Fixes for the example plugin Job in README #84

Merged
Roach merged 2 commits into from
Feb 5, 2018
Merged

Fixes for the example plugin Job in README #84

Roach merged 2 commits into from
Feb 5, 2018

Conversation

@finnito
Copy link
Contributor

@finnito finnito commented Oct 18, 2017 •
edited
Loading

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. Doc fixes for bot cron jobs

Related Issues

Fixes bot start errors because of missing module
Fixes error adding the job

Tests

Implemented the fixes in a plugin for my own bot and it worked.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Roach
Copy link
Contributor

Roach commented Oct 25, 2017

@finnito thanks for the patch! Would you mind signing the CLA linked above so we can get this merged?

@finnito
Copy link
Contributor Author

finnito commented Oct 25, 2017

@Roach Done!

@Roach Roach merged commit 6f58b55 into slack-samples:master Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@finnito @CLAassistant @Roach