Added resize parameters for dataset image reader, and the ability to loa... #18
Conversation
…load data from alternate directories
kastnerkyle
force-pushed
the
example_resizing
branch
from
005393e to
4a50c44
Compare
There was a problem hiding this comment.
How useful is this generalization? I can see it being pretty awesome if instead of a read_dir one could specify a read_glob. That way we wouldn't be stuck with JPG either and could load anything that PIL can load, e.g. PNG images. I think it's just a matter of importing glob and using it instead of os.listdir
There was a problem hiding this comment.
I think this would be nice - the only thing I don't know is what images PIL supports. I thought it was only jpg but I may be wrong. If it supports more than jpg I am 100% ok with opening up the glob as well.
There was a problem hiding this comment.
It supports a ton of different formats, PNG being the next most useful one here for us. I wouldn't want to exclude PNG.
There was a problem hiding this comment.
OK I am definitely ok with that. I would prefer to open it to arbitrary globbing without checking for compat or anything in this case!
There was a problem hiding this comment.
+1, let the user write globs such as /path/to/images/*sloth*.png
2 participants
...d data from alternate directories
cc @eickenberg
Added the ability to specify arbitrary directories for the load_sample_images and load_sample_image functions to enable loading "other data" easily.