Skip to content

M128 public#253

Merged
HinTak merged 27 commits into
skia-python:mainfrom
HinTak:m128-public
Jul 29, 2024
Merged

M128 public#253
HinTak merged 27 commits into
skia-python:mainfrom
HinTak:m128-public

Conversation

@HinTak

@HinTak HinTak commented Jul 27, 2024

Copy link
Copy Markdown
Collaborator

This is inclusive of #251 and #249 . The m128 update is fairly mundane, so I thought I'll put it through.

@kyamagu ready to go - please review - read the two new readme.127/128 first. While writing them, I thought it would be nice to have the skgpu aliases too, so I'll try something along that line before release.

HinTak added 24 commits June 1, 2024 07:13
one too many m127: GrVkBackendContext -> skgpu::VulkanBackendContext
Make skia.GrDirectContexts (namespace) an alias to skia.GrDirectContext
Make GrBackendRenderTargets (namespace) an alias to GrBackendRenderTarget

Allow direct call to GrBackendRenderTargets::MakeGL
Adding direct call to SkSurfaces::WrapBackendRenderTarget

Make Surface.Raster the same as Surface.MakeRaster
…yment target matches.

We need and build for 10.13 in Skia. The default is 10.9, too low for us.
Milestone 128
-------------

  * The following symbols (and their files) have been deleted in favor of their
    GPU-backend-agnostic form:
     - `GrVkBackendContext` -> `skgpu::VulkanBackendContext`
     - `GrVkExtensions` -> `skgpu::VulkanExtensions`
     - `GrVkMemoryAllocator` = `skgpu::VulkanMemoryAllocator`
     - `GrVkBackendMemory` = `skgpu::VulkanBackendMemory`
     - `GrVkAlloc` = `skgpu::VulkanAlloc`
     - `GrVkYcbcrConversionInfo` = `skgpu::VulkanYcbcrConversionInfo`
     - `GrVkGetProc` = `skgpu::VulkanGetProc`
--- skia-m127/include/core/SkRRect.h	2024-06-14 23:04:43.000000000 +0100
+++ skia-m128/include/core/SkRRect.h	2024-07-26 22:23:05.000000000 +0100
@@ -269,6 +270,10 @@
         @return        x-axis and y-axis radii for one corner
     */
     SkVector radii(Corner corner) const { return fRadii[corner]; }
+    /**
+     * Returns the corner radii for all four corners, in the same order as `Corner`.
+     */
+    SkSpan<const SkVector> radii() const { return SkSpan(fRadii, 4); }

     /** Returns bounds. Bounds may have zero width or zero height. Bounds right is
         greater than or equal to left; bounds bottom is greater than or equal to top.
@HinTak HinTak requested a review from kyamagu July 27, 2024 17:47
@HinTak

HinTak commented Jul 27, 2024

Copy link
Copy Markdown
Collaborator Author

This pull only adds 6 commits on top of #251 .

@HinTak

HinTak commented Jul 27, 2024

Copy link
Copy Markdown
Collaborator Author

Added the skgpu.* aliases.

@kyamagu kyamagu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finally solving the weird OpenGL behavior, LGTM :)

@HinTak HinTak merged commit ec0fe5b into skia-python:main Jul 29, 2024
@HinTak HinTak deleted the m128-public branch July 29, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants