M128 public#253
Merged
Merged
Conversation
…4875-gbe621ea042 on m126
…anvaskit/0.38.2-5214-g1c8089adff)
one too many m127: GrVkBackendContext -> skgpu::VulkanBackendContext
…iaSDLExample.cpp"
Make skia.GrDirectContexts (namespace) an alias to skia.GrDirectContext Make GrBackendRenderTargets (namespace) an alias to GrBackendRenderTarget Allow direct call to GrBackendRenderTargets::MakeGL
Adding direct call to SkSurfaces::WrapBackendRenderTarget Make Surface.Raster the same as Surface.MakeRaster
… 7 EOL on 1 Jul 2024 Upstream pull and issue: pypa/cibuildwheel#1917 pypa/cibuildwheel#1915
…yment target matches. We need and build for 10.13 in Skia. The default is 10.9, too low for us.
…t/0.38.2-5694-g5f2abc61e2)
Milestone 128
-------------
* The following symbols (and their files) have been deleted in favor of their
GPU-backend-agnostic form:
- `GrVkBackendContext` -> `skgpu::VulkanBackendContext`
- `GrVkExtensions` -> `skgpu::VulkanExtensions`
- `GrVkMemoryAllocator` = `skgpu::VulkanMemoryAllocator`
- `GrVkBackendMemory` = `skgpu::VulkanBackendMemory`
- `GrVkAlloc` = `skgpu::VulkanAlloc`
- `GrVkYcbcrConversionInfo` = `skgpu::VulkanYcbcrConversionInfo`
- `GrVkGetProc` = `skgpu::VulkanGetProc`
--- skia-m127/include/core/SkRRect.h 2024-06-14 23:04:43.000000000 +0100
+++ skia-m128/include/core/SkRRect.h 2024-07-26 22:23:05.000000000 +0100
@@ -269,6 +270,10 @@
@return x-axis and y-axis radii for one corner
*/
SkVector radii(Corner corner) const { return fRadii[corner]; }
+ /**
+ * Returns the corner radii for all four corners, in the same order as `Corner`.
+ */
+ SkSpan<const SkVector> radii() const { return SkSpan(fRadii, 4); }
/** Returns bounds. Bounds may have zero width or zero height. Bounds right is
greater than or equal to left; bounds bottom is greater than or equal to top.
Collaborator
Author
|
This pull only adds 6 commits on top of #251 . |
new skia.skgpu namespace, adapted from https://pybind11.readthedocs.io/en/stable/advanced/pycpp/object.html
Collaborator
Author
|
Added the skgpu.* aliases. |
kyamagu
approved these changes
Jul 29, 2024
kyamagu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for finally solving the weird OpenGL behavior, LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inclusive of #251 and #249 . The m128 update is fairly mundane, so I thought I'll put it through.
@kyamagu ready to go - please review - read the two new readme.127/128 first. While writing them, I thought it would be nice to have the skgpu aliases too, so I'll try something along that line before release.