Refactor updateHotkeyTip function #16282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

TCOTC wants to merge 1 commit into siyuan-note:dev from TCOTC:fix/updateHotkeyTip

+15 −12

Contributor

TCOTC commented Nov 4, 2025

AI 总结：

对 updateHotkeyTip 的重构包含以下优化，在保持功能不变的前提下，提升了性能和可维护性。

性能优化：将 KEY_MAP 从函数内部提升为模块级常量
- 避免每次调用都创建新的 Map
- 降低函数调用开销
健壮性提升：添加空值检查
- 在函数开始处检查 hotkey 是否为空
- 避免后续处理空字符串的问题
代码简化：
- 直接使用 Map 构造函数，替代 Object.entries() 转换
- 代码更直观
正则表达式优化：
- 将 /⌘|⇧|⌥|⌃/g 改为 /[⌘⇧⌥⌃]/g
- 使用字符类，更简洁且匹配效率更好


          ♻️ Refactor updateHotkeyTip function

321c369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet