Skip to content

The menu no longer extends beyond the window #15401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
+83 −34
Open

The menu no longer extends beyond the window #15401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e828496
:lipstick: The menu no longer extends beyond the window
TCOTC Aug 1, 2025
b37f65b
:art: The menu no longer extends beyond the window
TCOTC Aug 18, 2025
ce37930
:art: The menu no longer extends beyond the window
TCOTC Oct 7, 2025
1a0599d
:art: The menu no longer extends beyond the window
TCOTC Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
💄 The menu no longer extends beyond the window 
fix #15400
  • Loading branch information
@TCOTC
TCOTC committed Oct 7, 2025
commit e828496584ec30e9b792d3378826100209d1f66d
2 changes: 1 addition & 1 deletion app/src/assets/scss/component/_menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
}

&__items {
max-height: 80vh;
max-height: min(80vh, calc(100vh - 20px - var(--b3-menu-position-top, 0px))); // 20px 是 .b3-menu 的上下 padding
overflow: auto;
padding: 0 8px;
}
Expand Down
1 change: 1 addition & 0 deletions app/src/menus/Menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export class Menu {
this.element.style.zIndex = (++window.siyuan.zIndex).toString();
this.element.classList.remove("fn__none");
setPosition(this.element, options.x - (options.isLeft ? this.element.clientWidth : 0), options.y, options.h, options.w);
this.element.style.setProperty("--b3-menu-position-top", this.element.style.top);
}

public fullscreen(position: "bottom" | "all" = "all") {
Expand Down