Fix passing empty fragmentIdentifier to stringifyUrl()

sindresorhus · sindresorhus · commit cc232cb8cbeb · 2024-02-26T14:35:20.000+07:00
Fixes #380
diff --git a/base.js b/base.js
@@ -489,7 +489,7 @@ export function stringifyUrl(object, options) {
 	}
 
 	let hash = getHash(object.url);
-	if (object.fragmentIdentifier) {
+	if (typeof object.fragmentIdentifier === 'string') {
 		const urlObjectForFragmentEncode = new URL(url);
 		urlObjectForFragmentEncode.hash = object.fragmentIdentifier;
 		hash = options[encodeFragmentIdentifier] ? urlObjectForFragmentEncode.hash : `#${object.fragmentIdentifier}`;
diff --git a/test/stringify-url.js b/test/stringify-url.js
@@ -27,6 +27,7 @@ test('stringify URL with fragment identifier', t => {
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar', query: {}}), 'https://foo.bar');
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar', query: {}, fragmentIdentifier: 'foo bar'}), 'https://foo.bar#foo%20bar');
 	t.is(queryString.stringifyUrl({url: 'https://foo.bar/', query: {}, fragmentIdentifier: '/foo/bar'}), 'https://foo.bar/#/foo/bar');
+	t.is(queryString.stringifyUrl({url: 'https://foo.bar/#foo', query: {}, fragmentIdentifier: ''}), 'https://foo.bar/');
 });
 
 test('skipEmptyString:: stringify URL with a query string', t => {

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,7 @@ export function stringifyUrl(object, options) {`
`489`	`489`	`}`
`490`	`490`
`491`	`491`	`let hash = getHash(object.url);`
`492`		`- if (object.fragmentIdentifier) {`
	`492`	`+ if (typeof object.fragmentIdentifier === 'string') {`
`493`	`493`	`const urlObjectForFragmentEncode = new URL(url);`
`494`	`494`	`urlObjectForFragmentEncode.hash = object.fragmentIdentifier;`
`495`	`495`	hash = options[encodeFragmentIdentifier] ? urlObjectForFragmentEncode.hash : `#${object.fragmentIdentifier}`;