Repository navigation
fix(credentials): replay remembered refusals as credential errors, derive the delegable Google services list, and correct a fallback TSDoc - #9993
Merged
Conversation
…rive the delegable Google services list, and correct a fallback TSDoc
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge; no actionable issues were found. SummaryThis PR makes remembered credential refusals ask users to reconnect rather than wait for an outage to end.
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(credentials): replay remembered refu..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the final review of the v0.9.56 credential changes:
host_not_allowedorconsent_requiredis stored asprovider_unavailable. improvement(credentials): resolve agent fallback credentials once, Vanta 401 grace, true refusal codes, headless client-credential modes, and registry cleanups #9977 gave the first caller the real code, but every replay within the window still returnedprovider_unavailable, which maps to a 502 "temporarily unavailable". That told users to wait instead of fixing the credential.replayedFailurenow relabels a remembered refusal (isRememberedRefusal) toinvalid_credentialswith its stored status, which maps to "reconnect the credential". No new stored codes, so older builds still decode every memo.provider_unavailable.GOOGLE_DELEGATION_SERVICE_NAMESmoves next toGOOGLE_DELEGATION_SERVICESand is used by the keyless refusal messages and the connect dialog, so the wording can't drift from the list. The text is unchanged.credentialsTSDoc inmodel-fallback-request.tsnow says it is resolved once per call and shared by same-provider fallbacks.Type of Change
Testing
coordinated-client-token.integration.ts): run against a throwaway local Postgres, 56 tests withvanta-token.integration.ts.consent_requiredrefusal comes back asinvalid_credentials/ 400, and the exchange runs once. This fails on the previous code.provider_unavailable. This fails if the relabel is broadened to every 4xx.bun run lint,check:client-boundary,check:boundaries,check:comment-hygiene,check:test-patterns,check:explicit-any,check:test-typesandcheck:tool-registry-boundary --checkpass.Checklist
test-auditauthoring gate)