Skip to content

fix(aws-marketplace): confirm a container license lapse on a second re-check before switching Enterprise off - #9991

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/aws-marketplace-license-downgrade-confirmation
Nov 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/aws-marketplace-license-downgrade-confirmation

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • A running Enterprise deployment from the AWS Marketplace container listing now switches Enterprise off only after two consecutive "not entitled" re-checks. One spurious answer from License Manager no longer restarts a paying customer's replicas.
  • Any other answer (entitled, or a failed check) resets the count, so a lapse has to hold across consecutive re-checks. A real lapse takes effect one re-check (~15 minutes) later.
  • Turning Enterprise on still happens on the first entitled answer.

Type of Change

  • Bug fix

Testing

  • container-license.test.ts: 11 pass. New cases: a lapse restarts only on the second consecutive not-entitled re-check (for both NoEntitlementsAllowedException and ResourceNotFoundException), and a lone not-entitled answer followed by an entitled answer or a failed check never restarts.
  • Red→green: setting the confirmation count to 1 turns 4 tests red; dropping the reset on other answers turns 2 red.
  • biome, check:comment-hygiene, check:test-patterns.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 5:57am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Enterprise deployments now wait for two consecutive not-entitled re-checks before restarting.

  • Enterprise turns off only after two consecutive checks confirm a license lapse.

No actionable issues found. Tests were inspected, not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Running Enterprise deployment] --> B[Re-check license]
  B --> C{Answer}
  C -->|Entitled or failed check| D[Reset count]
  C -->|Not entitled| E[Add one to count]
  E --> F{Two consecutive answers?}
  F -->|No| G[Schedule next check]
  F -->|Yes| H[Schedule restart]
  D --> G
  G --> B
Loading

Reviews (1) · Last reviewed commit: "fix(aws-marketplace): confirm a containe..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 9bf50c9 into staging Nov 13, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/aws-marketplace-license-downgrade-confirmation branch November 13, 2026 08:03

This branch was previously deployed

1 inactive deployment
Preview — d4b24db5 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant