Repository navigation
chore(pii): drop the over-long text example from the mask client's outage comment - #9989
Merged
Merged
Conversation
…tage comment Presidio now masks texts over spaCy's length limit instead of answering 500, so the comment names a failure that still produces a deterministic 500
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 [Low impact] This comment-only change appears safe to merge. SummaryUpdates the
Reviews (1) · Last reviewed commit: "chore(pii): drop the over-long text exam..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OUTAGE_STATUSEScomment gave "an over-long text spaCy refuses" as its example of a deterministic Presidio 500. fix(pii): mask texts over spaCy's length limit and drop encoded files from logs #9979 made Presidio mask those texts, so the example now names an input that raises inside a recognizer. The behavior is unchanged (a 500 is retried but never read as an outage)Type of Change
Testing
bun run --cwd apps/sim test lib/guardrails/mask-client.test.ts: 10 passedcheck:comment-hygienepass locallyChecklist
test-auditauthoring gate)