Repository navigation
improvement(search): shorter Jira any-term budget and a shared batched read budget - #9984
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryShortens the any-term fallback timeout to two seconds and gives scaled MCP reads up to 20,000 encoded characters per document.
Reviews (2) · Last reviewed commit: "fix(search): reserve standard read pages..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limitthe client sends (a live document is one chunk, so the chunk limit never sized it). Clients almost never raisedlimit, so they got 8K pages and came back for continuationsnext. No document drops below the standard 8K page, so large batches read what they read todayType of Change
Testing
bun run test lib/sim-search lib/knowledge/mcp(527 passed); the newread-budget.test.ts, read-window and fallback-budget tests fail against the previous codeChecklist
test-auditauthoring gate)