Skip to content

fix(credentials): point the AWS keyless hint at the policy audience, quote the docs client ID, and correct a stale comment #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 13, 2026
+6 −5
Merged

fix(credentials): point the AWS keyless hint at the policy audience, quote the docs client ID, and correct a stale comment #9970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/docs/content/docs/integrations/aws-credentials.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ AWS accepts a token only when its audience is one of the identity provider's aud
```bash
aws iam add-client-id-to-open-id-connect-provider \
--open-id-connect-provider-arn arn:aws:iam::<account ID>:oidc-provider/<issuer host and path> \
--client-id <your audience>
--client-id '<your audience>'
```

A provider holds up to 100 audiences. Once no role relies on `sts.amazonaws.com` any more, you can remove it from the provider. Reconnecting the credential keeps its audience; clearing the field returns it to the default.
Expand Down
2 changes: 1 addition & 1 deletion ...[workspaceId]/integrations/components/connect-service-account-modal/aws-account-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ function AwsAccountForm({
<ChipModalField
type='custom'
title='Role trust policy'
hint='Enter the Role ARN first; the policy fills in its account ID. Add the issuer and audience above as an IAM identity provider (once per AWS account; if the provider exists, add the audience to it), set this as the role’s trust policy, then grant the role the permissions your workflows need.'
hint='Enter the Role ARN first; the policy fills in its account ID. Add the issuer above and the policy’s aud value as an IAM identity provider audience (once per AWS account; if the provider exists, add the audience to it), set this as the role’s trust policy, then grant the role the permissions your workflows need.'
>
{(aria) => (
<ChipTextarea
Expand Down
7 changes: 4 additions & 3 deletions apps/sim/lib/credentials/databricks-service-account.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,10 @@ async function verifyWorkspaceIdentity(

/**
* Sim signs tokens for any service principal a member names, and every Sim
* tenant shares the issuer and audience, so a federation policy that matches on
* a claim other than `sub` (a `subject_claim` of `sim_workspace_id`, say) would
* let other Sim credentials act as the principal. Exchanging a subject no
* tenant shares the issuer and can claim any audience (by default the same one),
* so a federation policy that matches on a claim other than `sub` (a
* `subject_claim` of `sim_workspace_id`, say) would let other Sim credentials act
* as the principal. Exchanging a subject no
* credential holds must be refused before the credential is saved.
*/
async function assertPolicyPinsSubject(
Expand Down
Loading