Skip to content

fix(credentials): point the AWS keyless hint at the policy audience, quote the docs client ID, and correct a stale comment - #9970

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/keyless-audience-polish
Nov 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/keyless-audience-polish

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Three small fixes from the final review of the configurable keyless audience (#9962):

  • AWS dialog hint: the Audience field is now an editable input, so the hint no longer says to copy "the audience above". It points to the trust policy's aud value, which always shows the audience in use, default or custom.
  • AWS docs: the add-client-id-to-open-id-connect-provider example quotes --client-id '<your audience>'. Allowed audiences can contain # and &, which the shell would misread unquoted.
  • Databricks TSDoc: a comment said every tenant shares the audience. Now that a credential can set its own, it says tenants share the issuer and can claim any audience. The subject-pin probe it explains is unchanged.

Type of Change

  • Bug fix

Testing

  • bun run lint passes.
  • check:comment-hygiene, check:docs and check:client-boundary pass.
  • The docs content:verify-compatibility check passes.
  • The AWS and Databricks server tests pass (43).
  • There is no behavior change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…quote the docs client ID, and correct a stale comment
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 13, 2026 1:24am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

This PR updates three pieces of text without changing runtime behavior:

  • The AWS role hint points to the audience in the trust policy.
  • The AWS setup command keeps audience values intact in the shell.
  • The Databricks check’s comment reflects custom audiences.

No actionable issues were found.

Reviews (1) · Last reviewed commit: "fix(credentials): point the AWS keyless ..." · Reviewed by Greptile

This branch was successfully deployed

1 active deployment
Preview — 6257b155 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant