Repository navigation
fix(credentials): point the AWS keyless hint at the policy audience, quote the docs client ID, and correct a stale comment - #9970
Merged
Conversation
…quote the docs client ID, and correct a stale comment
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] This PR appears safe to merge. SummaryThis PR updates three pieces of text without changing runtime behavior:
No actionable issues were found. Reviews (1) · Last reviewed commit: "fix(credentials): point the AWS keyless ..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes from the final review of the configurable keyless audience (#9962):
audvalue, which always shows the audience in use, default or custom.add-client-id-to-open-id-connect-providerexample quotes--client-id '<your audience>'. Allowed audiences can contain#and&, which the shell would misread unquoted.Type of Change
Testing
bun run lintpasses.check:comment-hygiene,check:docsandcheck:client-boundarypass.content:verify-compatibilitycheck passes.Checklist
test-auditauthoring gate)