fix(aws): round-trip typed DynamoDB cursors and allow percentile-only CloudWatch statistics by waleedlatif1 · Pull Request #9967 · simstudioai/sim

waleedlatif1 · 2026-11-13T00:40:57Z

Summary

Fixes from the v0.9.55 release review (#9963) that touch the AWS sweep (#9952/#9961).

DynamoDB pagination cursors round-trip for every key type.
- lastEvaluatedKey encoded integers a JS number can't hold, and binary keys, as plain strings. Passed back as exclusiveStartKey, they went out as S, so fetching the next page failed the key type check.
- The cursor now encodes those values as { N } / { B } (key attributes are always scalar, so this can't collide with a real key value), and exclusiveStartKey decodes them back to NumberValue / binary.
- String and safe-number cursors are unchanged, and item output is byte-identical.
- Not a regression from main, where these tables failed on page 1 (BigInt serialization).
CloudWatch get_metric_statistics accepts percentile-only requests.
- statistics is optional on the tool and in the contract, which now requires at least one of statistics / extendedStatistics.
- Direct and agent calls that pass only extendedStatistics no longer fail the required-param check.
- The block is unchanged: its Statistics field is still required and always populated, and ExtendedStatistics still takes precedence when both are set.

Not changed: the review note on dynamodb-get (expression attribute names without a projection) doesn't apply. tools/dynamodb/get.ts only forwards names together with a projection, and the contract has no other caller.

Type of Change

Bug fix

Testing

New regression tests, each red on the pre-fix code:
- DynamoDB cursor round trip: large-number and binary keys come back as N/B, while strings and safe numbers are unchanged.
- CloudWatch percentile-only request: passes the required-param check and the contract.
- The "neither statistic" rejection, pinned to the refine and guard-revert checked.
vitest across DynamoDB, CloudWatch, the AWS contracts, the stale-input test and the block tests: 45 passed.
check-block-registry.ts origin/staging, check:tool-metadata, check:docs, check:integration-catalog, check:unused-exports, check:utils, check:test-patterns, check:explicit-any, check:api-validation:strict and biome pass.
/simplify and /cleanup run on the diff.
Type-check runs in CI.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-11-13T00:40:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Nov 13, 2026 1:10am UTC

greptile-apps · 2026-11-13T00:43:40Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Preserves DynamoDB cursor types and allows CloudWatch requests that ask only for percentiles.

DynamoDB query and scan cursors keep binary and exact-number key types.
CloudWatch metric requests can use percentile statistics without standard statistics.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[DynamoDB page] --> B[Keep exact numbers and binary keys]
  B --> C[Encode typed cursor as JSON]
  C --> D[Next-page request]
  D --> E[Restore number and binary types]
  E --> F[DynamoDB next page]

_{Reviews (3) · Last reviewed commit: "fix(dynamodb): treat a number as exact o..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-13T00:54:04Z

@greptile

waleedlatif1 · 2026-11-13T00:54:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T00:54:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

… CloudWatch statistics Encode large-number and binary keys in lastEvaluatedKey as {N}/{B} and decode them in exclusiveStartKey, so pagination resumes on tables whose keys a JS number or string cannot carry. Item output is unchanged. Let get_metric_statistics take extendedStatistics alone: statistics is optional and the contract requires one of the two.

Hold every N value a JS number cannot represent exactly as a NumberValue so the cursor encodes it as {N}; item output keeps the same number/string rule.

…d-trips A decimal like 1.0000000000000000001 parses to a safe integer, so the safe-integer shortcut dropped its digits. Return a JS number only when String(parsed) equals the DynamoDB value (and it is not an unsafe integer); item output is unchanged.

waleedlatif1 · 2026-11-13T01:06:03Z

@greptile

waleedlatif1 · 2026-11-13T01:06:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-13T01:06:10Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

greptile-apps Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/dynamodb/client.ts Resolved

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/dynamodb/client.ts Resolved

vercel Bot deployed to Preview November 13, 2026 00:47

View deployment

vercel Bot temporarily deployed to Preview November 13, 2026 00:54 Inactive

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

waleedlatif1 added 3 commits November 12, 2026 17:05

fix(dynamodb): keep inexact decimal keys exact in pagination cursors

7e17913

Hold every N value a JS number cannot represent exactly as a NumberValue so the cursor encodes it as {N}; item output keeps the same number/string rule.

waleedlatif1 force-pushed the fix/atlassian-aws-release-review branch from 409b866 to fc0c438 Compare November 13, 2026 01:06

cubic-dev-ai Bot reviewed Nov 13, 2026

View reviewed changes

vercel Bot deployed to Preview November 13, 2026 01:10

View deployment

waleedlatif1 merged commit c79ff1a into staging Nov 13, 2026
83 checks passed

waleedlatif1 deleted the fix/atlassian-aws-release-review branch November 13, 2026 01:30

Conversation

waleedlatif1 commented Nov 13, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

waleedlatif1 commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 13, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 13, 2026 •

edited

Loading

greptile-apps Bot commented Nov 13, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading