Repository navigation
fix(desktop-browser): give a wait's closing snapshot a full budget and confirm ref reuse names the same element - #9966
Conversation
…d confirm ref reuse names the same element
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryGives
Reviews (3) · Last reviewed commit: "test(mothership): expect the wider brows..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Final-review follow-ups for the browser-agent changes in this release:
browser_wait_fornow ends with a snapshot, but its native watchdog still allowed only 5s after the wait. A wait that ran to its timeout on a heavy page could lose its closing observation and invalidate refs, where before it returnedfound: falsewith refs intact. The watchdog now adds a standalone snapshot's 20s budget; the renderer's wait budget (queue wait + timeout + 15s) still covers itbrowser_wait_forthat shadowed the module-levelelementTargetType of Change
Testing
Checklist
test-auditauthoring gate)