Repository navigation
fix(integrations): return the Dataverse page size and correct Contacts search outputs - #9965
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
 [Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds Dataverse’s sent
Reviews (2) · Last reviewed commit: "fix(integrations): document the null Dat..." · Reviewed by Greptile |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…s search outputs - Dataverse List Records returns the page size it sent (odata.maxpagesize) so a loop can pass it back with nextLink, since Dataverse requires the same value on every page; the request header and the output share one resolver - Page Size placeholder and input description now say the default applies only without Max Results and that the value must stay the same across Next Page Link pages - Google Contacts metadata description no longer claims search returns nextPageToken/totalItems
waleedlatif1
force-pushed
the
fix/release-9963-google-microsoft
branch
from
November 13, 2026 00:41
00bee48 to
9fa9c69
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These address the two release PR #9963 review threads on the Google/Microsoft integration sweep.
pageSize: the page size it actually sent asodata.maxpagesize, or null when Max Results applied instead.nextLinkpage, and the value can't be recovered from the link.resolvePageSizehelper, so they can't drift.metadatadescription no longer claims search returnsnextPageToken/totalItems. People APIsearchContactsreturns only results.Type of Change
Testing
vitestontools/microsoft_dataverseandblocks/blocks.test.ts: passing.check-block-registry.ts origin/stagingcheck:tool-metadata,check:docs,check:integration-catalogcheck:utils,check:test-patternsChecklist
test-auditauthoring gate)