Repository navigation
feat(credentials): configurable audience for keyless AWS, Databricks, Snowflake, Microsoft, and Google credentials - #9962
Merged
Conversation
… Snowflake, Microsoft, and Google credentials
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[High impact] The PR appears safe to merge; no new actionable issues remain. SummaryAdds custom audiences to keyless credentials for AWS, Databricks, Snowflake, Microsoft, and Google.
|
Contributor
There was a problem hiding this comment.
1 issue found across 37 files
Confidence score: 3/5
- In
google-keyless-fields.tsx, the displayed Google resource name can be persisted as a customaudienceinstead of being treated as the provider default. Normalize it againstproviderAudiencebefore building the value.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/google-keyless-fields.tsx">
<violation number="1" location="apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/google-keyless-fields.tsx:114">
P2: Typing the displayed Google provider resource name is persisted as a custom `audience`, because the shared setup has no Google-specific default to compare against. Normalize it against `providerAudience` before building the config so the default remains omitted and mixed-version pods continue accepting it.</violation>
</file>
…wing setup commands
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Nov 13, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audience(theaudclaim of the token Sim signs). A trust configuration can then pin a value specific to the customer instead of the shared default, so a Sim token isn't accepted somewhere it wasn't meant for. This covers all five keyless providers:audconditionaudiences. Databricks' own default is the account ID.OIDC_AUDIENCE_LIST. Snowflake's docs warn that the sharedsnowflakecomputing.comallows cross-account reuse.allowedAudiences. STS still exchanges at the provider resource name.workload-identity/audiences.ts:storedAudienceField, which stores nothing for the default.stored<X>ReconnectFieldsreader (one parse) instead of separate auth-type and audience readers.CREATE USER, gcloud--allowed-audiences.keylessConfig.audience.Type of Change
Testing
prepare-workload-identitycovers reconnect reopening on a custom audience for all five providers.audiences.test.tscovers the shared schema.lib/credentials,app/api/v2/credentialsandlib/api/contracts, plus 554 sim-cli tests.bun run lintandcheck-block-registry.ts origin/stagingpass.check:openapi,check:cli-api,check:cli-docs,check:mcp-operations,check:api-validation:strict,check:test-patterns,check:comment-hygiene,check:explicit-any,check:client-boundary,check:boundaries,check:utils,check:file-namesandcheck:docs.CreateOpenIDConnectProvider, Databricks federation policy API, Snowflake workload identity federation, Entra federated identity credentials, Google workload identity pool providers).Checklist
test-auditauthoring gate)