fix(integrations): final review pass for the Atlassian and AWS sweeps by waleedlatif1 · Pull Request #9961 · simstudioai/sim

waleedlatif1 · 2026-11-12T23:03:02Z

Summary

Final-review follow-up for the Atlassian (#9950) and AWS (#9952) validation sweeps. An independent review of both merged diffs found no blockers. This PR applies the should-fix and nit findings. Everything changed here was added by those two PRs and isn't on main yet, so production behaviour is unaffected.

Atlassian

Jira search: the heavy per-issue fields fix(atlassian): validate Jira, Confluence, JSM, Bitbucket, Trello against vendor docs #9950 added (descriptionAdf, customFields, attachments, issuelinks, subtasks) are now opt-in through fields, so default searches don't carry every customfield_* into agent prompts. renderedDescription needs the renderedFields expansion. Every field that exists on main keeps its exact value.
Moved transformIssueData into tools/jira/utils.ts with a typed raw payload (no any), shared by retrieve and search.
JSM Assets AQL: a trailing order by is split only at parenthesis depth 0 (still honouring quotes and escapes), and a leading order by with a scope filter produces valid AQL.
JSM object types: if the /flat fallback itself fails, the result is the original empty list, so the fallback can't add a new failure mode. Aborts still propagate.
Confluence search and search-in-space send next=true with a cursor, as Confluence's own _links.next does.
Agent-call hardening:
- Trello update accepts label/member IDs as an array or a comma-separated string.
- A blank Jira parent is treated as unset.
- A numeric Confluence parentCommentId no longer throws.
JSM types include renderedValue.

AWS

New toBooleanFromInput in @sim/utils/coerce replaces the two local copies in Secrets Manager and CloudFormation. The duplicates in google_docs/blocks/utils belong to the Workspace sweep and migrate separately.
The IAM tags schema moves into iam-shared, and the SES message-tag schema into ses-shared.
SES send tools accept emailTags as a JSON string from agent calls.
Secrets Manager names the field on invalid JSON.
IAM accepts JSON-array tag strings and skips null tag values.
Textract rejects a JSON-object query string instead of sending it as question text, and the size error no longer suggests Multi-Page mode for operations that lack it.

Type of Change

Bug fix
Code quality

Testing

New regression tests, each red on the pre-fix code:
- JSM: AQL splitting and the flat fallback.
- Trello: ID list input.
- Jira: search heavy fields and blank parent.
- Confluence: numeric comment id and next=true paging.
The transformIssueData move was checked for output equivalence on sample payloads.
vitest across the Atlassian and AWS tools, internal ops, block tests, tools/google_docs and packages/utils: 443 + 120 passed.
check-block-registry.ts origin/staging, check:tool-metadata, check:docs, check:integration-catalog, check:unused-exports, check:utils, check:test-patterns and biome pass. Type-check and the remaining audits run in CI.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-11-12T23:03:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Nov 12, 2026 11:38pm UTC

greptile-apps · 2026-11-12T23:06:39Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues remain.

Summary

This PR hardens inputs across the Atlassian and AWS tools and shares repeated helpers and schemas.

Jira searches return heavy issue details only when callers ask for them.
JSM Assets keeps scoped queries valid and preserves empty fallback results.
Confluence search resumes pages with both the cursor and next=true.
Atlassian tools accept common agent-call forms for IDs and parent fields.
SES send tools accept message tags passed as a JSON string.
AWS tools accept more agent-friendly tag, boolean, and JSON inputs.
Textract rejects object-shaped query text and clarifies its size-limit guidance.

No new actionable issues were found. Tests were inspected but not run.

_{Reviews (3) · Last reviewed commit: "fix(textract): use isRecordLike for the ..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 40 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-12T23:19:13Z

@greptile

waleedlatif1 · 2026-11-12T23:19:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-12T23:19:19Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 43 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

Make Jira search heavy fields (ADF description, custom fields, attachments, links, subtasks) opt-in through fields, move transformIssueData into jira/utils, keep AQL order by splitting at parenthesis depth 0, let the object-types /flat fallback never add a failure, send next=true with Confluence search cursors, and harden Trello ID lists, Jira parent, and Confluence comment ids for agent calls.

Share the optional-boolean parse through @sim/utils/coerce toBooleanFromInput, the IAM tags schema through iam-shared, and the SES message-tag schema through ses-shared. Accept SES email tags as a JSON string from agent calls, name the field on Secrets Manager JSON errors, accept JSON-array IAM tag strings and skip null tag values, and reject a JSON-object Textract query string.

Treat only a leading [ as a JSON Textract query list, reject JSON-array IAM tag strings and SES email-tag strings that do not parse to valid entries, name Secrets Manager tag JSON errors, restore the JSM list TSDoc placement, and shrink the explicit-any baseline after the Jira mapper move.

… parse, keep null IAM tag values as empty

waleedlatif1 · 2026-11-12T23:34:08Z

@greptile

waleedlatif1 · 2026-11-12T23:34:10Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-12T23:34:16Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 43 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

vercel Bot deployed to Preview November 12, 2026 23:09

View deployment

waleedlatif1 force-pushed the fix/integrations-final-pass branch from ccaebfb to 5289f4a Compare November 12, 2026 23:18

vercel Bot deployed to Preview November 12, 2026 23:23

View deployment

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/iam.ts Resolved

greptile-apps Bot reviewed Nov 12, 2026

View reviewed changes

Comment thread apps/sim/blocks/blocks/textract.ts Resolved

waleedlatif1 added 5 commits November 12, 2026 15:31

fix(integrations): reject JSON-object Textract queries only when they…

139e5db

… parse, keep null IAM tag values as empty

fix(textract): use isRecordLike for the JSON-object query check

fb29195

waleedlatif1 force-pushed the fix/integrations-final-pass branch from 5289f4a to fb29195 Compare November 12, 2026 23:34

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

vercel Bot deployed to Preview November 12, 2026 23:38

View deployment

waleedlatif1 merged commit b266bd9 into staging Nov 12, 2026
89 checks passed

waleedlatif1 deleted the fix/integrations-final-pass branch November 12, 2026 23:41

Conversation

waleedlatif1 commented Nov 12, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 12, 2026 •

edited

Loading

greptile-apps Bot commented Nov 12, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading