Repository navigation
fix(integrations): close stale and empty value leaks from the Google and Microsoft sweeps - #9960
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no new actionable defects remain. SummaryThe PR prevents empty defaults and values saved for other operations from reaching Google and Microsoft tools.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 51 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…and Microsoft sweeps Final staging-to-main review of #9947, #9954 and #9949. The executor merges raw subBlock values under the block mapper's output, so a value stored for another operation (or an empty default the serializer fills in) reached tools whenever the mapper skipped that key. - Outlook: reply, reply-all and forward always set cc/bcc, so a Send cc never reaches them; send and draft always set importance; the new Importance dropdown defaults to unset - Google Groups Update Settings assigns every setting, so unchanged settings are never sent as '' - Google Tasks List assigns its tri-state filters and the tool skips empty values - OneDrive "If File Exists" defaults to unset so opening an old upload block sends nothing new - Google Sheets clears a Batch Get major dimension for every other operation - Azure DevOps: List Pipelines and Get Comments keep main's Max Results fallback, each paged operation has its own continuation token, and multi-item reads omit the raw field bag - SharePoint upload drops "." folder segments as before and still rejects ".." - Entra transitive and includeManager use one strict flag check; Dataverse treats a cleared page size as unset - Behaviour-neutral cleanups: shared header lookup (Gmail), settings mapper (Groups), identity and metadata outputs (Word), isSet (Dataverse), graphPathSegment (SharePoint), typed identity reads (Azure DevOps), Teams fallback payload nulls
…ale Outlook importance on replies
waleedlatif1
force-pushed
the
fix/workspace-suites-final-pass
branch
from
November 12, 2026 23:18
3eb9bee to
691ac24
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR comes from a final staging→main review of the Google (#9947, #9954) and Microsoft (#9949) integration sweeps. The review targeted backwards compatibility for workflows saved on main. Most fixes share one root cause:
{ ...inputs, ...transformedParams }.value: () => '', and keeps advanced values when advanced options are collapsed.Fixes:
cc/bcc. Before, a CC saved while the block was on Send was added to replies and forwards after switching operations.importance. Before, an Update Message importance leaked into sends.'', where main sent an empty PATCH.showHidden=&showDeleted=&showAssigned=were sent when advanced options were shown.conflictBehavior=replace..folder segments are dropped, as on main...is still rejected.transitiveandincludeManageruse one strict check, so"false"stays off.isSet.graphPathSegment.vi.stubGlobal.Type of Change
Testing
vitestacross 62 files: 555 passed, covering the touched tools, blocks, internal operations, webhook providers andblocks.test.ts.check-block-registry.ts origin/stagingcheck:tool-metadata,check:docs,check:integration-catalogcheck:utils,check:test-patternsChecklist
test-auditauthoring gate)