Skip to content

fix(gitlab): require confirmed emails in permission exports - #9958

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/gitlab-confirmed-permission-export
Nov 12, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/gitlab-confirmed-permission-export

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Require a valid GitLab email-confirmation timestamp before exporting a reader, matching the existing permission resolver.
  • Cover unconfirmed, missing, and invalid confirmation data through the HTTPS exporter test and document the directory requirements.

Type of Change

  • Bug fix

Testing

  • All 19 HTTPS exporter checks pass, including CSV validation through the existing Sim parser and grant resolver.
  • Regression fails on the previous exporter; removing either confirmation guard fails its targeted case.
  • Root tests, lint, type-check, audits, block registry check, and documentation compatibility.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 12, 2026 10:57pm UTC

Request Review

@waleedlatif1
waleedlatif1 marked this pull request as draft November 12, 2026 22:48
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The exporter now requires a readable confirmed_at value that Python can parse before adding a reader to either CSV.

  • GitLab exports now leave out readers without confirmed emails.

Reviews (2) · Last reviewed commit: "fix(gitlab): require confirmed emails in..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 marked this pull request as ready for review November 12, 2026 22:50
@waleedlatif1
waleedlatif1 force-pushed the codex/gitlab-confirmed-permission-export branch from 660a47d to 6c04fb8 Compare November 12, 2026 22:50
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 6c04fb85 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant