Repository navigation
improvement(desktop-browser): click through a nested control that fills the whole target - #9956
Conversation
…ls the whole target
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryAllows native clicks through one nested control that fills the target and reports
Reviews (3) · Last reviewed commit: "test(desktop-browser): exercise the form..." · Reviewed by Greptile |
… a control that covers the whole target
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- The top-level-window gate in
page-functions.tsrejects same-origin iframe targets, so the new click-through behavior won’t work inside those frames. Adjust the gate to preserve framed clicks.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/desktop/src/main/browser-agent/page-functions.ts">
<violation number="1" location="apps/desktop/src/main/browser-agent/page-functions.ts:1547">
P3: This top-level-window gate makes the new click-through behavior refuse every same-origin iframe target, even though `clickElement` already translates frame coordinates and the driver supports native framed clicks. Remove the `window.top === window` restriction so a fully covered control behaves consistently inside same-origin frames.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
browser_clickon a target whose whole area is one nested control (a time-slot label filling its link) now clicks there — what a person clicking the target hits — and reportsclickedThrough, instead of refusing with "lands on X, which is its own control inside that element"Type of Change
Testing
page-functions.test.ts(fills-the-target clicks through; partial cover still refuses); 541 browser-agent tests passChecklist
test-auditauthoring gate)