Repository navigation
fix(google): close post-merge verification gaps from the Workspace sweep - #9954
Conversation
- Sheets V2 Append gets its own Value Input Option field so a value stored for Write/Update no longer reaches Append
- Sheets legacy read guards the spreadsheet id; the COLUMNS check only fires when a filter actually runs
- Calendar reminders accept the API's {overrides} object; updatedMin notes deleted events are included
- Drive search skips orderBy for fullText queries, which Drive rejects
- Docs number parsing ignores booleans; Tasks trims a blank task list id to @default
- Forms trigger respondentEmail marked optional; Slides block exposes layout/notes/master properties
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThis PR fixes Google Workspace input and output gaps while preserving saved Sheets Append behavior.
Reviews (3) · Last reviewed commit: "fix(google): require a boolean useDefaul..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… values, accept numeric task list ids
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…and Microsoft sweeps Final staging-to-main review of #9947, #9954 and #9949. The executor merges raw subBlock values under the block mapper's output, so a value stored for another operation (or an empty default the serializer fills in) reached tools whenever the mapper skipped that key. - Outlook: reply, reply-all and forward always set cc/bcc, so a Send cc never reaches them; send and draft always set importance; the new Importance dropdown defaults to unset - Google Groups Update Settings assigns every setting, so unchanged settings are never sent as '' - Google Tasks List assigns its tri-state filters and the tool skips empty values - OneDrive "If File Exists" defaults to unset so opening an old upload block sends nothing new - Google Sheets clears a Batch Get major dimension for every other operation - Azure DevOps: List Pipelines and Get Comments keep main's Max Results fallback, each paged operation has its own continuation token, and multi-item reads omit the raw field bag - SharePoint upload drops "." folder segments as before and still rejects ".." - Entra transitive and includeManager use one strict flag check; Dataverse treats a cleared page size as unset - Behaviour-neutral cleanups: shared header lookup (Gmail), settings mapper (Groups), identity and metadata outputs (Word), isSet (Dataverse), graphPathSegment (SharePoint), typed identity reads (Azure DevOps), Teams fallback payload nulls
…and Microsoft sweeps (#9960) * fix(integrations): close stale and empty value leaks from the Google and Microsoft sweeps Final staging-to-main review of #9947, #9954 and #9949. The executor merges raw subBlock values under the block mapper's output, so a value stored for another operation (or an empty default the serializer fills in) reached tools whenever the mapper skipped that key. - Outlook: reply, reply-all and forward always set cc/bcc, so a Send cc never reaches them; send and draft always set importance; the new Importance dropdown defaults to unset - Google Groups Update Settings assigns every setting, so unchanged settings are never sent as '' - Google Tasks List assigns its tri-state filters and the tool skips empty values - OneDrive "If File Exists" defaults to unset so opening an old upload block sends nothing new - Google Sheets clears a Batch Get major dimension for every other operation - Azure DevOps: List Pipelines and Get Comments keep main's Max Results fallback, each paged operation has its own continuation token, and multi-item reads omit the raw field bag - SharePoint upload drops "." folder segments as before and still rejects ".." - Entra transitive and includeManager use one strict flag check; Dataverse treats a cleared page size as unset - Behaviour-neutral cleanups: shared header lookup (Gmail), settings mapper (Groups), identity and metadata outputs (Word), isSet (Dataverse), graphPathSegment (SharePoint), typed identity reads (Azure DevOps), Teams fallback payload nulls * fix(integrations): render Azure DevOps list outputs in docs, clear stale Outlook importance on replies
Summary
Follow-up to #9947. Each Google integration was re-verified individually against its API discovery doc after merge, with a check for regressions in saved workflows. Two of these fixes close regressions; the rest are hardening.
appendValueInputOptionfield and ignores the shared one, so saved workflows send exactly what they sent before fix(google): validate Workspace integrations, return dropped fields and expose missing params #9947.safeUrlPathSegment, matching the other v1 tools. The COLUMNS check now fires only when a filter actually runs (column and value both set).{useDefault, overrides}object, so<prev.reminders>can be wired in directly.updatedMindescription now notes that events deleted since that time are always included.fullTextqueries, which Drive rejects. It was opt-in and new in fix(google): validate Workspace integrations, return dropped fields and expose missing params #9947.@default.respondentEmailis marked optional.layoutProperties,notesPropertiesandmasterPropertiesfrom Get Page.Type of Change
Testing
vitestovertools/google_sheets,tools/google_calendar,tools/gmail,blocks/blocks.test.tsandlib/webhooks/providers: 470 passedcheck-block-registry.ts origin/staging,check:tool-metadata,check:docs,check:integration-catalog,check:utils,check:test-patterns, explicit-any, and biome.Checklist
test-auditauthoring gate)