Skip to content

fix(google): close post-merge verification gaps from the Workspace sweep - #9954

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/google-suite-followup
Nov 12, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/google-suite-followup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #9947. Each Google integration was re-verified individually against its API discovery doc after merge, with a check for regressions in saved workflows. Two of these fixes close regressions; the rest are hardening.

Type of Change

  • Bug fix

Testing

  • vitest over tools/google_sheets, tools/google_calendar, tools/gmail, blocks/blocks.test.ts and lib/webhooks/providers: 470 passed
  • These checks pass: check-block-registry.ts origin/staging, check:tool-metadata, check:docs, check:integration-catalog, check:utils, check:test-patterns, explicit-any, and biome.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

- Sheets V2 Append gets its own Value Input Option field so a value stored for Write/Update no longer reaches Append
- Sheets legacy read guards the spreadsheet id; the COLUMNS check only fires when a filter actually runs
- Calendar reminders accept the API's {overrides} object; updatedMin notes deleted events are included
- Drive search skips orderBy for fullText queries, which Drive rejects
- Docs number parsing ignores booleans; Tasks trims a blank task list id to @default
- Forms trigger respondentEmail marked optional; Slides block exposes layout/notes/master properties
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 12, 2026 9:36pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

This PR fixes Google Workspace input and output gaps while preserving saved Sheets Append behavior.

  • Sheets Append uses its own value input choice.
  • Calendar event writes accept reminder settings copied from an event.
  • Drive full-text searches follow relevance ordering.
  • Legacy Sheets reads safely place spreadsheet IDs in request paths.
  • Sheets reads check column filters only when a filter value is set.
  • Slides Get Page outputs include layout, notes, and master properties.
  • Docs number parsing ignores boolean inputs.
  • Blank task list IDs use the default task list.
  • Calendar's updatedMin description notes that deleted events are included.
  • Google Forms marks respondent email as optional output.

Reviews (3) · Last reviewed commit: "fix(google): require a boolean useDefaul..." · Reviewed by Greptile

Comment thread apps/sim/tools/google_calendar/utils.ts Resolved
Comment thread apps/sim/tools/google_drive/search.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/google_sheets.ts Resolved
Comment thread apps/sim/tools/google_calendar/utils.ts Resolved
Comment thread apps/sim/tools/google_sheets/read.ts Resolved
Comment thread apps/sim/tools/google_tasks/types.ts Resolved
Comment thread apps/sim/tools/google_drive/search.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/google_calendar/utils.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4a5b2c6 into staging Nov 12, 2026
82 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/google-suite-followup branch November 12, 2026 21:44
waleedlatif1 added a commit that referenced this pull request Nov 12, 2026
…and Microsoft sweeps

Final staging-to-main review of #9947, #9954 and #9949. The executor merges raw subBlock values
under the block mapper's output, so a value stored for another operation (or an empty default the
serializer fills in) reached tools whenever the mapper skipped that key.

- Outlook: reply, reply-all and forward always set cc/bcc, so a Send cc never reaches them; send
  and draft always set importance; the new Importance dropdown defaults to unset
- Google Groups Update Settings assigns every setting, so unchanged settings are never sent as ''
- Google Tasks List assigns its tri-state filters and the tool skips empty values
- OneDrive "If File Exists" defaults to unset so opening an old upload block sends nothing new
- Google Sheets clears a Batch Get major dimension for every other operation
- Azure DevOps: List Pipelines and Get Comments keep main's Max Results fallback, each paged
  operation has its own continuation token, and multi-item reads omit the raw field bag
- SharePoint upload drops "." folder segments as before and still rejects ".."
- Entra transitive and includeManager use one strict flag check; Dataverse treats a cleared page
  size as unset
- Behaviour-neutral cleanups: shared header lookup (Gmail), settings mapper (Groups), identity and
  metadata outputs (Word), isSet (Dataverse), graphPathSegment (SharePoint), typed identity reads
  (Azure DevOps), Teams fallback payload nulls
waleedlatif1 added a commit that referenced this pull request Nov 12, 2026
…and Microsoft sweeps (#9960)

* fix(integrations): close stale and empty value leaks from the Google and Microsoft sweeps

Final staging-to-main review of #9947, #9954 and #9949. The executor merges raw subBlock values
under the block mapper's output, so a value stored for another operation (or an empty default the
serializer fills in) reached tools whenever the mapper skipped that key.

- Outlook: reply, reply-all and forward always set cc/bcc, so a Send cc never reaches them; send
  and draft always set importance; the new Importance dropdown defaults to unset
- Google Groups Update Settings assigns every setting, so unchanged settings are never sent as ''
- Google Tasks List assigns its tri-state filters and the tool skips empty values
- OneDrive "If File Exists" defaults to unset so opening an old upload block sends nothing new
- Google Sheets clears a Batch Get major dimension for every other operation
- Azure DevOps: List Pipelines and Get Comments keep main's Max Results fallback, each paged
  operation has its own continuation token, and multi-item reads omit the raw field bag
- SharePoint upload drops "." folder segments as before and still rejects ".."
- Entra transitive and includeManager use one strict flag check; Dataverse treats a cleared page
  size as unset
- Behaviour-neutral cleanups: shared header lookup (Gmail), settings mapper (Groups), identity and
  metadata outputs (Word), isSet (Dataverse), graphPathSegment (SharePoint), typed identity reads
  (Azure DevOps), Teams fallback payload nulls

* fix(integrations): render Azure DevOps list outputs in docs, clear stale Outlook importance on replies

This branch was previously deployed

1 inactive deployment
Preview — fa027ebd Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant