Repository navigation
improvement(desktop-browser): stable element refs, wait observations, and fewer false refusals - #9953
Conversation
…le their element lives
…ared frame and observe helpers
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new blocking issue was found. SummaryThe PR keeps browser element refs stable, adds fresh observations after waits, and allows typing through non-modal covers.
Reviews (3) · Last reviewed commit: "fix(desktop-browser): bound remembered r..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
browser_wait_forends with a fresh snapshot, so the model doesn't spend a round re-observingbrowser_typetypes into a top-page field covered by a non-modal overlay (keyboard focus, as Playwrightfilldoes); modal backgrounds and framed fields still refuseType of Change
Testing
page-functions.test.ts,driver.test.ts,post-action-observation.test.ts); 534 browser-agent tests passcheck:auditsonly failed knip on the docs app's generated.contentimport, andbun run testonly failed two desktop tests that also fail on staging when run as root (permission-refusal tests)Checklist
test-auditauthoring gate)