Repository navigation
fix(aws): validate AWS integrations against SDK and API docs - #9952
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The PR appears safe to merge, with no new actionable findings confirmed. SummaryThis PR fixes AWS result conversion and signing, adds optional request fields, and exposes more AWS response details.
No new actionable findings were confirmed. Tests were inspected, not run.
|
d7b1391 to
4acd3b6
Compare
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
4acd3b6 to
0fe163d
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 181 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
0fe163d to
847ce42
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 181 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
847ce42 to
2c8316c
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
2c8316c to
4ceeb88
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 181 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
Fixes DynamoDB items failing or serializing as {} (BigInt, sets, binary), RDS
SELECT rowCount always 0, Athena dropping the first row of DDL results, SES
templated/bulk sends missing Reply-To and bulk Cc/Bcc, Lambda dropdowns forcing
values on update, and binary Secrets Manager secrets. Adds missing documented
params and dropped response fields across the suite. All changes are additive.
The executor merges raw block inputs under the mapped params, so new params named like an existing subBlock picked up values from other operations or empty table rows. Always assign those keys in the block mappers (DynamoDB, SES, CloudFormation, IAM, STS), tolerate string booleans and blank values in the affected tools, add the remaining SDK partition SQS hosts, split long non-ASCII SES From names into RFC 2047 words, and address review findings.
Send no IAM usage filter for All, assign Secrets Manager create/update KMS key and tags explicitly, accept object or key/value IAM tag rows, reject non-array SES email tags, require DynamoDB parallel-scan segments together and below the total, restrict string scanIndexForward to true/false, and fix SES test typing.
Attachment authorization goes through context.userId, the same shared boundary other integrations use; adding a new file-egress path is out of scope for a compatibility-first validation sweep.
4ceeb88 to
36cc4b2
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 180 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
Summary
Response.jsonthrew. Those numbers now come back as exact strings.{}and now come back as arrays.projectionExpression,consistentRead,indexName, parallel scansegment/totalSegments, andreturnValueson put, delete and update. Update still defaults toALL_NEW.scannedCountand table stream/ARN fields.rowCountwas always 0 and is now the row count. Writes are unchanged.parametersbinding (withtypeHint) for query/execute;generatedFieldsreturned.expectedBucketOwnerandclientRequestToken; executionathenaError, timings andengineVersion; column label, precision and scale.ccAddresses/bccAddresses, which used to be silently stripped. Malformed values are still dropped rather than failing the send.fromNameandemailTags(validated against the SES tag rules).tenantId, application/system log levels, GetFunctioncode.errorandtagsError.!'()*are now signed the way the SDK signs them; other keys sign identically.jobStatus/statusMessage/warnings(partial success). Sync input over AWS's 10 MB limit fails fast instead of downloading 100 MB first.ExtendedStatistics) and unit on metric statistics.SourceIdentity.tools.config.params.{}sets and index-object binary.Follow-ups (not in this PR)
context.userId, the shared tool-file boundary; the new egress path should land with that boundary taking the acting principal.TemplateURL, which needs a contract change to maketemplateBodyoptional.Type of Change
Testing
@smithy/signature-v4vitestover every touchedtools/,lib/internal/and block test for these services, pluslib/api/contracts/tools/aws: 220 passed.check-block-registry.ts origin/staging,check:tool-metadata,check:docs,check:integration-catalogand biome pass.check:auditsrun in CI.Checklist
test-auditauthoring gate)