Repository navigation
fix(atlassian): validate Jira, Confluence, JSM, Bitbucket, Trello against vendor docs - #9950
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The PR appears safe to merge; no new actionable issue was established, and the numbered attachment-download finding is fixed. SummaryUpdates Jira, Confluence, JSM, Bitbucket, and Trello tools and blocks.
|
There was a problem hiding this comment.
All reported issues were addressed across 87 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
9519c3c to
3a2c84c
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 88 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
3a2c84c to
5a289ec
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 88 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
5a289ec to
23972c8
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
23972c8 to
b8972a5
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 88 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…inst vendor docs Fixes JSM Assets AQL search returning no objects (legacy request/response shape), adds missing documented params and dropped response fields across the suite, and routes path IDs through safeUrlPathSegment. All changes are additive: no param, subBlock, operation, tool id, or output is removed or retyped.
Keep trailing AQL and CQL order by clauses after scoped filters, honor escaped quotes, reject JSM approvalStatus/organizationId outside their ownership modes, move Trello card outputs into types.ts so the docs render them, and drop the now-unused Confluence COMMENTS_OUTPUT.
…en output types
PUT /cards/{id} documents idLabels/idMembers as comma-separated strings.
Treat a whitespace-only Jira parent as unset, mark nullable Trello card
outputs, document the new Trello types, and type the Confluence search test.
…ring includeAttachments
b8972a5 to
e08f208
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 89 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
Summary
/object/aqlsent paging in the body and read the legacyobjectEntries/totalFilterCountshape. It now sendsstartAt/maxResults/includeAttributesas query params with{qlQuery}as the body, and readsvalues/total/isLast, per the Assets OpenAPI spec.objectTypeId/objectSchemaIdare now applied: they are ANDed into the AQL (numeric only) and keep any trailingorder by. Before, they were sent in the body and silently ignored.startAt,maxResultsandisLastoutputs./objectschema/{id}/objecttypesresponse now falls back to the documented/objecttypes/flat, withexcludeAbstractapplied client-side. Non-empty responses are untouched and make no extra request.ORGANIZATION/ALL_ORGANIZATIONSownership values (they were rejected before), plus newapprovalStatusandorganizationId.webUrlandrequestFieldValues.renderedValue.participants/slas.names. Search gainsexpand.customFields; Update gainsparent; Transition gains screenfields.includeAttachmentsis reachable from the block.safeUrlPathSegment, including the delete tools.authorId/createdAt(read fromversion), Atlas Doc Format comment bodies, SearchspaceKey/space.id(viaexpand=content.space), and spacedescription(viadescription-format=plain).createdAt/fileId, and space owner/webUrl.include/exclude/path.board_fieldslacked the requiredurl).dueComplete: null(it now sendsfields=all).start,pos,shortUrl,badges,idMembersand friends.start; Update gainspos,idBoard,idLabelsandidMembers.since/before.safeUrlPathSegment.tools.config.params, so stale values can't leak between operations.Follow-ups (not in this PR)
trigger_pipelinedeclares scopepipeline, but the docs saypipeline:write. Left alone because credential resolution reads it.limit/checklists/attachments/membersare documented only in the nested-resources guide, not the OpenAPI spec, so they were left out.confluenceEmail/confluenceApiToken/includeFileContentare never read.Type of Change
Testing
order bypreservation, object-types/flatfallback,ORGANIZATIONownership.vitestovertools/{jira,jsm,bitbucket,trello,confluence},lib/internal/{jira,jsm,confluence,bitbucket}, the Jira/Bitbucket webhook providers, triggers and the block tests: 310 passed.check-block-registry.ts origin/staging,check:tool-metadata,check:docs,check:integration-catalogand biome pass.check:auditsrun in CI.Checklist
test-auditauthoring gate)