Skip to content

fix(atlassian): validate Jira, Confluence, JSM, Bitbucket, Trello against vendor docs - #9950

Merged
waleedlatif1 merged 5 commits into
stagingfrom
fix/atlassian-suite-validation
Nov 12, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
fix/atlassian-suite-validation

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • JSM Assets search returned no objects for every valid AQL query. /object/aql sent paging in the body and read the legacy objectEntries/totalFilterCount shape. It now sends startAt/maxResults/includeAttributes as query params with {qlQuery} as the body, and reads values/total/isLast, per the Assets OpenAPI spec.
    • objectTypeId/objectSchemaId are now applied: they are ANDed into the AQL (numeric only) and keep any trailing order by. Before, they were sent in the body and silently ignored.
    • New startAt, maxResults and isLast outputs.
  • JSM List Object Types: an empty /objectschema/{id}/objecttypes response now falls back to the documented /objecttypes/flat, with excludeAbstract applied client-side. Non-empty responses are untouched and make no extra request.
  • JSM requests:
    • Get Requests accepts the documented ORGANIZATION/ALL_ORGANIZATIONS ownership values (they were rejected before), plus new approvalStatus and organizationId.
    • Get and Create Request return webUrl and requestFieldValues.renderedValue.
    • Get Request returns expanded participants/slas.
    • Request type and comment visibility filters are reachable from the block.
  • Jira:
    • Search and Read now return the fields they already request: custom fields, parent, fixVersions, subtasks, issue links, time tracking, creator, watchers, ADF description and names. Search gains expand.
    • Write and Update accept typed customFields; Update gains parent; Transition gains screen fields.
    • includeAttachments is reachable from the block.
    • Path IDs go through safeUrlPathSegment, including the delete tools.
  • Confluence:
    • Fields that were always empty or null are now populated: List Comments authorId/createdAt (read from version), Atlas Doc Format comment bodies, Search spaceKey/space.id (via expand=content.space), and space description (via description-format=plain).
    • New: CQL and cursor paging on search, inline comments with replies, page owner/parent/labels, attachment createdAt/fileId, and space owner/webUrl.
  • Bitbucket:
    • List Commits gains include/exclude/path.
    • Trigger Pipeline can target tags. Its restricted ref target is unchanged: no selector, variables or runner.
    • PR endpoints return the allowed and default merge strategies.
    • Webhook provider log messages are static.
  • Trello:
    • Search failed whenever a board matched (board_fields lacked the required url).
    • Get Card always returned dueComplete: null (it now sends fields=all).
    • Card outputs gain start, pos, shortUrl, badges, idMembers and friends.
    • Create and Update gain start; Update gains pos, idBoard, idLabels and idMembers.
    • Search gains paging; List Cards gains since/before.
    • All path IDs go through safeUrlPathSegment.
  • Backwards compatibility:
    • No param, subBlock id, operation value, tool id or output was removed, renamed or retyped, and no default changed.
    • New block fields are scoped to their own operations in tools.config.params, so stale values can't leak between operations.
    • The only output values that change are ones that were previously empty, null or erroring.

Follow-ups (not in this PR)

  • Bitbucket trigger_pipeline declares scope pipeline, but the docs say pipeline:write. Left alone because credential resolution reads it.
  • Trello list-card limit/checklists/attachments/members are documented only in the nested-resources guide, not the OpenAPI spec, so they were left out.
  • Confluence trigger confluenceEmail/confluenceApiToken/includeFileContent are never read.

Type of Change

  • Bug fix
  • New feature (additive params and outputs)

Testing

  • New regression tests, each red on the pre-fix code:
    • JSM: AQL request and response shape, scope injection guard, order by preservation, object-types /flat fallback, ORGANIZATION ownership.
    • Confluence: comment author/created time, search space key.
  • vitest over tools/{jira,jsm,bitbucket,trello,confluence}, lib/internal/{jira,jsm,confluence,bitbucket}, the Jira/Bitbucket webhook providers, triggers and the block tests: 310 passed.
  • check-block-registry.ts origin/staging, check:tool-metadata, check:docs, check:integration-catalog and biome pass.
  • An independent review of the full diff checked it against the Atlassian and Trello OpenAPI specs.
  • Type-check and check:audits run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 12, 2026 10:24pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new actionable issue was established, and the numbered attachment-download finding is fixed.

Summary

Updates Jira, Confluence, JSM, Bitbucket, and Trello tools and blocks.

  • JSM tools return Assets search results and more request details.
  • Jira tools return more issue fields and accept more write options.
  • Confluence tools return more page, comment, search, and space details.
  • Trello card tools search, update, and return more card details.
  • Bitbucket tools filter commits and can target pipeline tags.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Block inputs] --> B[Tool parameters]
  B --> C[Check and build request]
  C --> D[Vendor API]
  D --> E[Map returned fields]
  E --> F[Workflow outputs]
Loading

Reviews (6) · Last reviewed commit: "fix(jira): keep explicit assignee ahead ..." · Reviewed by Greptile

Comment thread apps/sim/tools/trello/update_card.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 87 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/confluence/get_space.ts Resolved
Comment thread apps/sim/blocks/blocks/trello.ts Resolved
Comment thread apps/sim/lib/internal/jsm/assets.ts Resolved
Comment thread apps/sim/blocks/blocks/bitbucket.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the fix/atlassian-suite-validation branch from 9519c3c to 3a2c84c Compare November 12, 2026 20:50
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 88 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/trello/types.ts Resolved
Comment thread apps/sim/tools/trello/types.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 88 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/trello/types.ts Resolved
Comment thread apps/sim/tools/trello/types.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the fix/atlassian-suite-validation branch from 5a289ec to 23972c8 Compare November 12, 2026 21:44
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/jira.ts Resolved
…inst vendor docs

Fixes JSM Assets AQL search returning no objects (legacy request/response
shape), adds missing documented params and dropped response fields across the
suite, and routes path IDs through safeUrlPathSegment. All changes are additive:
no param, subBlock, operation, tool id, or output is removed or retyped.
Keep trailing AQL and CQL order by clauses after scoped filters, honor escaped
quotes, reject JSM approvalStatus/organizationId outside their ownership modes,
move Trello card outputs into types.ts so the docs render them, and drop the
now-unused Confluence COMMENTS_OUTPUT.
…en output types

PUT /cards/{id} documents idLabels/idMembers as comma-separated strings.
Treat a whitespace-only Jira parent as unset, mark nullable Trello card
outputs, document the new Trello types, and type the Confluence search test.
@waleedlatif1
waleedlatif1 force-pushed the fix/atlassian-suite-validation branch from b8972a5 to e08f208 Compare November 12, 2026 22:19
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 89 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — e08f208d Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant