Repository navigation
fix(api): report a finished run's real status once its pauses have settled; show the request id in the CLI - #9924
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryFinished runs now report their saved status once all pause points have settled. CLI errors also show the server’s request ID and keep their exit code when rewritten.
Reviews (3) · Last reviewed commit: "fix(cli): read an internal route's reque..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
paused(witherror: null) by Get workflow run and in the run list, because any open pause record overrode the finished log. When a resume fails, the run's log is marked failed and the pointfailedin the same transaction, and admission refuses any point that isn'tpaused, so nothing can resume it again. The run is now reported aspausedonly while a point can still be resumed. Once the log has finished and every point has resumed or failed, it reports the finished status, its error, and the failing block, like any other failed run. Seen in production on a run whose time pause resumed and then a later block failed.paused, includingpartially_resumedruns and finished runs that still have a waiting point. Cancellation's rollback of a failed point happens while the log is still running, so it's unaffected. The workspace paused-runs list and the approval link already required a waiting point.PAUSE_POINT_ROWSSQL helper (both pause-point storage shapes), which the paused-runs list now also uses.pausedstatus description is updated to match.requestId(orx-request-idwhen the body has none) is now shown on CLI errors: in the JSON error object and as arequest id:line in human output. Rewritten errors also keep their exit code, which was previously reset to 1.Test plan