Skip to content

feat(apollo): add optional OAuth connections - #9922

Open
waleedlatif1 wants to merge 1 commit into
stagingfrom
codex/apollo-oauth
Open

feat(apollo): add optional OAuth connections#9922
waleedlatif1 wants to merge 1 commit into
stagingfrom
codex/apollo-oauth

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Apollo OAuth connections alongside existing saved and inline API keys.
  • Support partner authorization, rotating refresh tokens, and self-hosted client setup; offer OAuth only when its client is configured.
  • Validate mixed credential pickers while preserving the existing API-key request path.

Type of Change

  • New feature

Testing

  • Apollo OAuth protocol and profile validation tests, including negative controls for URL encoding, provider identity, and response byte limits
  • Saved-credential contract and sibling credential, block, and availability tests
  • Live OAuth code exchange, profile verification, bearer-token API request, rotating refresh, and refreshed-token read (5/5 checks)
  • Full repository lint, type-check, audits, tests, and block-registry checks

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 12, 2026 3:49am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes add a new OAuth route for Apollo and affect its connected workflows.

The PR appears safe to merge, with a non-blocking fix needed to hide unavailable Apollo OAuth setup.

Findings

  1. P2 OAuth offered without setup ▶

Summary

Adds optional Apollo OAuth alongside saved and inline API keys.

  • Apollo users can connect their account to Sim with OAuth.
  • Apollo tools use the matching header for saved OAuth tokens and API keys.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Picker[Apollo credential picker] --> Key[Saved API key]
  Picker --> OAuth[OAuth connection]
  Key --> Header[X-Api-Key header]
  OAuth --> Token[Resolve or refresh access token]
  Token --> Bearer[Authorization Bearer header]
  Header --> Apollo[Apollo API]
  Bearer --> Apollo
Loading

Reviews (1) · Last reviewed commit: "feat(apollo): add optional OAuth connect..." · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Nov 12, 2026
View reviewed changes
Comment thread apps/sim/blocks/blocks/apollo.ts
type: 'oauth-input',
serviceId: 'apollo',
title: 'Apollo Credential',
credentialKind: 'any',

@greptile-apps greptile-apps Bot Nov 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 OAuth offered without setup

If APOLLO_CLIENT_ID or APOLLO_CLIENT_SECRET is missing, changing this picker to credentialKind: 'any' still shows “Connect Apollo account.” The merged picker always includes that action, but the server requires a configured client before starting OAuth. Self-hosted users can open and submit a connection that cannot work.

Hide the OAuth action unless the client is ready, while keeping saved credentials and API-key setup available.

Knowledge Base Used: Integrations, connectors, and tools

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 12, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 47 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — 301bf8a6 Deployed Nov 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1