feat(aws-marketplace): sell several listings from one integration through a product catalog by waleedlatif1 · Pull Request #9920 · simstudioai/sim

waleedlatif1 · 2026-11-12T02:27:00Z

Summary

One integration now sells any number of AWS Marketplace listings. Each listing's behavior is a plan in code (aws-marketplace/products.ts); which product codes exist is deployment configuration, AWS_MARKETPLACE_PRODUCTS=<code>=<plan>,.... Every path resolves a license's product from the code AWS returned or the code on its row, so adding, repricing, or retiring a listing is a config change, not a branch
Plans: contract (unchanged behavior: any current entitlement grants access) and platform-with-usage (access requires a current platform entitlement; usage dimensions never grant access on their own)
entitlementCount still counts every dimension AWS returned, so a license with usage but no platform reads inactive, not pending
Registration routes by the code ResolveCustomer returns, since all listings share the one fulfillment URL; a code this deployment doesn't sell is refused as before
Reconcile and the daily re-verify span every configured code and verify each license against its own product; agreement renewals, advisories and endings match across listings (agreement IDs are unique anyway)
The team's "organizations already linked to this AWS account" hint now matches across listings — a buyer moving to a new listing usually wants the organization they already have — and team notices name the listing
config.ts is the single parse point (memoized); a malformed AWS_MARKETPLACE_PRODUCTS throws an error naming the bad entry on first use. env.ts stays free of billing code
Reconcile resolves the configured products once per run and the repository returns each license paired with its product, so no loop re-looks-up or skips

Deploy prerequisite: this replaces AWS_MARKETPLACE_PRODUCT_CODE. Before the release carrying this PR deploys, the production env secret must hold AWS_MARKETPLACE_PRODUCTS=<existing code>=contract; otherwise the Marketplace surfaces turn off. The new listing is added to that value (and to the infra event rule) once this is live.

Type of Change

New feature

Testing

lifecycle.integration.ts + checkout-guard.integration.ts on real Postgres (bun run test:integration): 75 pass, including two new ones — a usage-listing buyer is admitted only on a current platform entitlement (a usage-only license is recorded inactive), and a queued License Updated event for the usage listing is applied under its own plan (a lapsed platform ends access while usage is current). Both go red with the dimension filter removed
entitlements.test.ts: 10 pass; the 3 new required-dimension cases go red with the filter removed
tsc --noEmit, bun run lint, and check:boundaries, check:client-boundary, check:utils, check:file-names, check:comment-hygiene, check:source-conventions, check:explicit-any; full audits and suites run in CI

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ough a product catalog

vercel · 2026-11-12T02:27:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 12, 2026 2:55am UTC

greptile-apps · 2026-11-12T02:30:23Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge with the documented production configuration change.

Summary

Adds a configured product catalog so one AWS Marketplace integration can sell several listings.

One deployment can sell several AWS Marketplace listings.
Each Marketplace license uses its listing’s access rule.
License rechecks and team notices cover every configured listing.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Config[AWS_MARKETPLACE_PRODUCTS] --> Catalog[Product catalog]
  Registration[AWS registration token] --> Resolve[ResolveCustomer]
  Resolve --> Catalog
  Events[License events and daily checks] --> Catalog
  Catalog --> Verify[Read entitlements using the listing plan]
  Verify --> Seen[Record the license when AWS describes it]
  Seen --> Access{Current required entitlement?}
  Access -->|Yes|Active[Active]
  Access -->|No|Other[Pending or inactive]

_{Reviews (3) · Last reviewed commit: "fix(aws-marketplace): discover a license..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 17 files

_{Turn on auto-fix | Re-trigger cubic}

…env free of billing code, and drop derivable state

…ss, and refuse to boot on a malformed product catalog

waleedlatif1 · 2026-11-12T02:41:29Z

@greptile

waleedlatif1 · 2026-11-12T02:41:30Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-12T02:41:35Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 18 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…ide access from the plan's dimension

waleedlatif1 · 2026-11-12T02:55:13Z

Re the outside-diff finding (usage-only licenses go unrecorded): valid, fixed in 3caea36. The overloaded entitlementCount is replaced by two explicit facts on the summary: licenseSeen (AWS returned any entitlement, so the license exists and names its account; decides whether a row is created) and accessReported (AWS returned the access dimension, current or lapsed; decides status, registration retries, and which fields are written). A License Updated event that arrives first with only llm_credits now creates the row as pending and tells the team it is unconfirmed; a new integration test covers it and fails when row creation keys off access.

waleedlatif1 · 2026-11-12T02:55:14Z

@greptile

waleedlatif1 · 2026-11-12T02:55:15Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-12T02:55:20Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 18 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

feat(aws-marketplace): sell several listings from one integration thr…

e99cece

…ough a product catalog

vercel Bot temporarily deployed to Preview November 12, 2026 02:27 Inactive

greptile-apps Bot reviewed Nov 12, 2026

View reviewed changes

Comment thread apps/sim/lib/core/config/env.ts Resolved

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

Comment thread apps/sim/lib/core/config/env.ts Resolved

Comment thread apps/sim/lib/billing/aws-marketplace/registration.ts Resolved

improvement(aws-marketplace): resolve each run's products once, keep …

35e9a84

…env free of billing code, and drop derivable state

vercel Bot temporarily deployed to Preview November 12, 2026 02:33 Inactive

fix(aws-marketplace): treat a usage-only read as no answer about acce…

a78c117

…ss, and refuse to boot on a malformed product catalog

vercel Bot temporarily deployed to Preview November 12, 2026 02:41 Inactive

This comment has been minimized.

Sign in to view

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

fix(aws-marketplace): discover a license from any entitlement and dec…

3caea36

…ide access from the plan's dimension

vercel Bot temporarily deployed to Preview November 12, 2026 02:55 Inactive

cubic-dev-ai Bot reviewed Nov 12, 2026

View reviewed changes

waleedlatif1 merged commit 392dc44 into staging Nov 12, 2026
80 checks passed

waleedlatif1 deleted the feat/aws-marketplace-product-catalog branch November 12, 2026 03:06

Conversation

waleedlatif1 commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 12, 2026

Uh oh!

This comment has been minimized.

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

waleedlatif1 commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 12, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Nov 12, 2026 •

edited

Loading

vercel Bot commented Nov 12, 2026 •

edited

Loading

greptile-apps Bot commented Nov 12, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading