Repository navigation
feat(aws-marketplace): gate Enterprise on the AWS Marketplace container license and add the EKS install profile - #9917
Conversation
…er license and add the EKS install profile
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[High impact] The PR appears safe to merge; no new blocking issue was found. SummaryAdds AWS Marketplace license checks before server startup and an EKS install profile backed by RDS and ElastiCache.
|
There was a problem hiding this comment.
1 issue found across 7 files
Confidence score: 2/5
container-license.tslets any individual Enterprise feature flag bypass the Marketplace check, so unlicensed customers may get Enterprise features. Make Marketplace license state authoritative over those flags.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/billing/aws-marketplace/container-license.ts">
<violation number="1" location="apps/sim/lib/billing/aws-marketplace/container-license.ts:44">
P1: The Marketplace check can be bypassed by setting any individual Enterprise feature flag, because this change only disables the master switch and feature flags explicitly override it. Make Marketplace license state the entitlement source for every Enterprise feature, or reject/clear per-feature overrides when the SKU is configured.</violation>
</file>
…, scope the IAM role to it, and bump the chart
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…he RDS username tied to the template, and note why the license is read in the pod's Region
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
AWS_MARKETPLACE_LICENSE_PRODUCT_SKUset), the container entrypoint reads the buyer's AWS License Manager licenses for this product before the server loads, withListReceivedLicensesfiltered to the product SKU and the AWS Marketplace issuer fingerprint. A license that License Manager reportsAVAILABLEand that carries theenterprise_licenseentitlement setsENTERPRISE_ENABLEDand its browser twin, so every existing Enterprise gate reads the answer unchangedexamples/values-aws-marketplace.yaml, the EKS profile the Marketplace chart ships as its defaults:cronimage for scheduled jobs in place ofcurlimages/curl.helm testbusybox hook is off for the same reason.examples/aws-marketplace-prerequisites.yaml, a CloudFormation template for the buyer's account:license-manager:ListReceivedLicenses.@aws-sdk/client-license-manager3.1162.0, the same version as the other AWS clients. It goes throughawsRequestHandler, soHTTPS_PROXYis honoredType of Change
Testing
helm lintandhelm templatewith the new profile, alone and withci/default-values.yaml, the way the chart CI renders every example. Rendered images are onlysimstudioai/{simstudio,realtime,migrations,cron}aws cloudformation validate-templateandcfn-lintpass. cfn-lint's only warning is the major-onlyEngineVersion: '17', kept on purpose so RDS picks the current minorbun run lint, pluscheck:egress-boundary,check:source-conventions,check:utils,check:file-names,check:comment-hygiene,check:explicit-anyandcheck:boundaries. The full audits, type-check and tests run in CIChecklist
test-auditauthoring gate)