Skip to content

improvement(table): document that a column selection matching no column returns empty row data - #9915

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/table-columns-contract-doc-sim34
Nov 12, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/table-columns-contract-doc-sim34

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Clarifies the documented columns contract for row queries. A reference that matches no column is ignored, and if none match, each row's data is empty. The old wording ("a reference that matches no column is ignored") could be read as falling back to every column when nothing matches.
  • No behavior change. Failing closed is intentional: widening a stale selection to every column would return cells the caller deliberately excluded. This behavior is already live for the v2 query API.
  • The two row-query tools (table_query_rows, table_query_rows_v2) now share one TABLE_COLUMNS_PARAM in tools/table/params.ts, following TABLE_ID_PARAM, so their parameter descriptions can't drift apart. The contract description (rowColumnSelectionSchema) stays separate because it documents the API field.
  • Regenerated tool-metadata.ts and the Table integration docs page.

Type of Change

  • Documentation / improvement (no behavior change)

Testing

  • Ran the table tool and internal table operation suites (tools/table, lib/internal/table, the table block tests, lib/api/contracts): all pass.
  • Ran check:docs, check:api-validation:strict and check:comment-hygiene. The pre-push lint:check and type-check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 12, 2026 12:50am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; the clarified descriptions match the existing query behavior.

Summary

Clarifies that a nonempty columns selection matching no column returns empty row data.

  • Row-query docs explain what happens when no selected columns match.

Reviews (1) · Last reviewed commit: "improvement(table): document that a colu..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/table/params.ts Resolved
@waleedlatif1
waleedlatif1 merged commit d026560 into staging Nov 12, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/table-columns-contract-doc-sim34 branch November 12, 2026 01:14

This branch was successfully deployed

1 active deployment
Preview — 0f9fb777 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant