Repository navigation
improvement(table): document that a column selection matching no column returns empty row data - #9915
Merged
Conversation
…mn returns empty row data
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] This PR appears safe to merge; the clarified descriptions match the existing query behavior. SummaryClarifies that a nonempty
Reviews (1) · Last reviewed commit: "improvement(table): document that a colu..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
columnscontract for row queries. A reference that matches no column is ignored, and if none match, each row's data is empty. The old wording ("a reference that matches no column is ignored") could be read as falling back to every column when nothing matches.table_query_rows,table_query_rows_v2) now share oneTABLE_COLUMNS_PARAMintools/table/params.ts, followingTABLE_ID_PARAM, so their parameter descriptions can't drift apart. The contract description (rowColumnSelectionSchema) stays separate because it documents the API field.tool-metadata.tsand the Table integration docs page.Type of Change
Testing
tools/table,lib/internal/table, the table block tests,lib/api/contracts): all pass.check:docs,check:api-validation:strictandcheck:comment-hygiene. The pre-pushlint:checkandtype-checkpass.Checklist
test-auditauthoring gate)