Repository navigation
fix(credentials): match JSON 403s case-insensitively and refuse a malformed ZoomInfo access token - #9914
Merged
Conversation
…formed ZoomInfo access token - isVendorJsonForbidden lowercases Content-Type before matching, since media types are case-insensitive; a vendor 403 sent as Application/JSON no longer rejects a live key that only lacks a scope. - requestZoomInfoToken requires a non-blank string access_token, so the saved-credential minter and the legacy inline path never cache or send a malformed token.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 [Medium impact] This PR appears safe to merge. SummaryThis PR fixes two credential checks:
No actionable issues found. Tests were reviewed but not run. Reviews (1) · Last reviewed commit: "fix(credentials): match JSON 403s case-i..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isVendorJsonForbiddenlowercasesContent-Typebefore matching, because media types are case-insensitive. Before, a vendor 403 sent asApplication/JSONwas treated as a firewall page, so a live key that only lacked a scope was rejected. This covers HubSpot and everyforbiddenMeansScopedtoken check.requestZoomInfoTokennow requiresaccess_tokento be a non-blank string. A blank or non-string token used to be cached and sent as a Bearer token. The saved-credential minter and the legacy inline ZoomInfo path both call this function, so both are covered. Theexpires_infallback is unchanged.Type of Change
Testing
hubspot.test.ts, and blank and non-stringaccess_tokeninzoominfo/client.test.ts. All of them fail on the pre-fix code and pass after.lib/internal/zoominfoand the ZoomInfo minter.bun run lint,check:test-patterns,check:comment-hygiene,check:utilsandcheck:explicit-anypass, and so does the type-check in the pre-push hook.Checklist
test-auditauthoring gate)