Repository navigation
fix(security): refuse an extra slash after https:// in typed base URLs - #9913
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryThis PR rejects an extra slash or backslash immediately after
Reviews (1) · Last reviewed commit: "fix(security): refuse an extra slash aft..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refuseUnsafeUrlFormnow refuses a slash or backslash right afterhttp(s)://. The URL parser skips those, sohttps:///user:pass@hostslipped pastrefuseUnsafeTypedUrl's authority check and a caller's normalizer silently dropped the credentialsnormalizeHttpBaseUrlandrefuseUnsafeTypedUrlinherit it (GitLab, ServiceNow, Infisical, EmailBison, Jupyter, Logfire and the other typed-host validators)host:portsuch asftp:123is unchanged: every caller prefixeshttps://, so it stays a host and portType of Change
Testing
input-validation.test.ts: two new cases fail on the old guard and pass now (141 passing)Checklist
test-auditauthoring gate)