Skip to content

chore(deps): bump turbo to 2.11.10 - #9903

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/deps-turbo
Nov 11, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
chore/deps-turbo

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps turbo 2.9.14 → 2.11.10 (root devDependency; the Docker prune stages read the version from it). Schema URL moved to v2-11-10.
  • Landing route-group globs. app/(landing)/** was never a valid glob: ( starts a group in Turborepo's glob engine. 2.9.14 skipped the bad glob in turbo query (so landing edits fell into ci:shared and selected every suite) and failed turbo run on any ci:* task outright. 2.11 falls back to "every task affected" for the whole repo. Wrote the folder as a character class, app/[(]landing[)]/**, which matches the literal folder in both affected detection and hashing.
  • Task-level affectedTasks needs a future flag in 2.11. Since fix: Include virtual tasks in affected query vercel/turborepo#13805 (2.10.x), affectedTasks matches turbo run --affected: without futureFlags.affectedUsingTaskInputs or futureFlags.filterUsingTasks, it reports every task of an affected package. Enabled filterUsingTasks. CI's --filter calls only name packages, so they select the same tasks (checked with --dry=json). affectedUsingTaskInputs would also work, but it makes turbo prune @sim/app keep apps/desktop, apps/docs, and apps/realtime, because @sim/app tasks depend on pkg#task there, and the app image build relies on desktop being pruned away.
  • Prerequisites in affectedTasks.items. 2.11 also lists the runnable prerequisites of affected tasks (reason "required by an affected task"). docs#build is one for ci:e2e-docs-platform, so every backend change would have run the full docs-site suite. ci-plan.gql now picks docs#build with its own task filter, which Turborepo applies before it adds prerequisites. No other task ci-plan.ts reads is a prerequisite of anything.
  • Added a ci-changes case for a landing route-group edit (it selects only SEO). It fails with the old glob.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: dependency upgrade

Testing

  • scripts/ci-changes.test.ts (real git + real Turborepo fixtures): 63/63 pass on 2.11.10. The 62 existing expectations are unchanged. Reverting each fix turns tests red: the glob fallback breaks broadly, the missing flag gives "package is affected" for every ci:* task, and dropping the docs selection fails the two platform-docs cases.
  • Full root scripts suite (vitest --config scripts/vitest.config.ts): 43 files, 744 tests pass.
  • Ran turbo query on this repo for the last 27 staging commits that don't touch orchestration. 2.9.14 and 2.11.10 selected identical non-prerequisite tasks and the same docs-site decision on every one.
  • Cache inputs (turbo run ci:shared ci:e2e-seo build --filter=@sim/app --dry=json): ci:shared, ci:server, and ci:ui hash 0 landing files, while ci:e2e-seo and build hash the whole app/(landing) tree. With the old glob, turbo run on these tasks fails with "Invalid glob" on both versions.
  • turbo prune @sim/app --docker gives identical out/json with and without the flag (apps: sim only). check:realtime-prune passes, and bun install --frozen-lockfile is clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner November 11, 2026 21:43
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 11, 2026 9:48pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread package.json Resolved
@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain from this review.

Summary

Updates Turborepo from 2.9.14 to 2.11.10 and adjusts CI task selection.

  • CI planning uses Turborepo 2.11.10 with task-based matching enabled.
  • Landing route-group edits match the literal folder and select the SEO path.
  • Docs-site checks use a separate query for the docs build task.

Changes since the previous review only update .github/CI.md. Those updates match the current configuration and planner. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "docs(ci): describe the Turborepo 2.11 ta..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant