Repository navigation
chore(deps): bump tiptap to 3.32.2 and keep headings that open a list item - #9898
Merged
Merged
Conversation
… item Bump every @tiptap/* package to 3.32.2 and raise the root prosemirror-transform override to 1.12.4 (@tiptap/pm 3.32 requires ^1.12.2). @tiptap/extension-list 3.32 demotes a heading that opens a list item to the item's paragraph, so `- # Title` loaded and saved as `- Title`. CommonMark reads it as a heading inside the item, which the Sim schema already supports; MarkdownListItem now parses that case as blocks itself. @tiptap/y-tiptap stays on 3.0.7: 3.0.8+ replaces a list's Yjs element when a sibling is merged into it, discarding concurrent peer edits inside the list.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates Tiptap to 3.32.2 and preserves headings that start list items.
Author Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "chore(deps): bump tiptap to 3.32.2 and k..." · Reviewed by Greptile |
This was referenced Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tiptap/*package inapps/simfrom 3.31.4 to 3.32.2.prosemirror-transformoverride from 1.12.0 to 1.12.4, since@tiptap/pm3.32 requires^1.12.2. 1.12.1 through 1.12.4 are bug fixes only, and 1.12.4 fixes a step-deserialization bug introduced in 1.12.3. The other prosemirror overrides already satisfy 3.32.2. Transitiveprosemirror-commands/-history/-dropcursor/-changesetpatch bumps come in through@tiptap/pm.list-item.ts):@tiptap/extension-list3.32 now turns a heading at the start of a list item into the item's paragraph and drops its level. With that change, opening a file containing- # Titleand saving it rewrote it as- Title. CommonMark reads- # Titleas a heading inside the list item, and Sim's schema already supports that:MarkdownListItemputs an empty paragraph first. The override now parses that case as blocks itself, so the output is the same as on 3.31.4.@tiptap/y-tiptapstays on 3.0.7 on purpose. From 3.0.8 on, a new reconcile path pairs the unanchored children by position. When one transaction merges a block into the list after it (for example, typing-above a list, ortoggleBulletListjoining the list below), y-tiptap deletes the list'sY.XmlElementand recreates it. Edits a peer made inside that list at the same time are lost on every client, and the clients still converge, so nothing reports an error. The same code is still in the latest release (3.3.0). It has the same root cause as the open upstream issue y-tiptap 3.2.0: lifting a list item replaces the list's Yjs element, losing or duplicating concurrent edits ueberdosis/tiptap#8735.@tiptap/extension-collaboration3.32.2 accepts^3.0.7.Type of Change
Testing
rich-markdown-editor/folder in one vitest run: 716/716 pass. With y-tiptap 3.0.9, 5 tests fail (list-collaborationjoin and undo tests, plus 2image-collaborationtests). Reverting thelist-item.tsfix makesheading-image(- # Before  after) fail again.lib/collab-doc/(the converter, seed, merge, and persist tests that use tiptap): 82/82 pass.!-before-link escape. Every case gives the same output on 3.31.4 and on 3.32.2 with the fix.toggleBulletListon the paragraph above). On 3.0.7 both clients keep B's text. On 3.0.9 both clients converge without it.bun install --frozen-lockfileis clean. The lockfile only changes@tiptap/*and the prosemirror packages.Checklist
🤖 Generated with Claude Code