Repository navigation
chore(deps): bump streamdown to 2.7.1 - #9897
Merged
Merged
Conversation
Streamdown 2.6+ hands streaming placeholders (streamdown:incomplete-link, streamdown:incomplete-image) to custom components instead of stripping them, so the mothership chat link and image renderers now withhold those until the URL completes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryUpgrades
Reviews (1) · Last reviewed commit: "chore(deps): bump streamdown to 2.7.1" · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamdown2.5.0 → 2.7.1 inapps/simand the@sim/workflow-rendererdevDependency (its>=2.5.0peer floor is unchanged; nothing here needs 2.7). Lockfile:remend1.3.0 → 1.4.0, and streamdown no longer pullsmermaid(Sim's own pinnedmermaidis unaffected).markedwas already forced to 18.0.11 by the root override, which 2.7 now targets officially.src="streamdown:incomplete-image"/href="streamdown:incomplete-link". The mothership chat overridesimganda, so without a change a streaming image showed a broken<img>inside a clickable Lightbox, and a streaming link became atarget=_blankanchor to a bogus URL.chat-content.tsxnow withholds a pending image (same as 2.5, which dropped it) and renders a pending link as its text until the URL completes (2.5 showed gray "partial link [blocked]" text).chat-content.tsxthat cited 2.5's minified memo internals (E/qe), which 2.6 changed. The remount itself is unchanged.codeDownloadwas never used). The newcodeBlockMaxHeightandtableMaxHeightdefaults don't reach Sim, because every surface overridescode/preandtable.Type of Change
Testing
I server-rendered (
react-dom/server) Sim's real components with the same inputs on 2.5.0 and on 2.7.1: mothershipChatContent(static/reload path, streaming path, and four partial streaming chunks), the deployed-chatMarkdownRenderer, and the workflow noteNoteBlockView(plain and with search highlight). The markdown covered headings, inline code, links, an autolink, a reference link, a remote image, an inline file image, a table, atsfence, a mermaid fence,$…<…$math, and a loose list. Then I diffed the HTML.rehype-hardenconfig (allowedImagePrefixes: ["*"]) and the prop-replaces-defaults merge are unchanged. The inline file reference is still rewritten to/api/mothership/chats/<chat>/images/<request>?path=…byprivateImageUrls.data-sd-animated(2.6 animate rework).[text][label]with its definition in another block now resolves to a link (2.7.1 fix). On 2.5 it rendered as raw text.$$ \sum_{j<k} $$no longer truncates the rest of the reply (2.7 fix). On 2.5, every block after the<, including the following paragraph and the list, was silently dropped while streaming.<img>and anchor.@sim/workflow-renderertype-check andsearch-highlight.test.tsxpass.chat-content/external-link.test.tsxpasses.bun install --frozen-lockfileis clean.stagger: 0,duration: 220. SSR can't show timing, so please glance at a live streamed reply.Checklist
🤖 Generated with Claude Code