Repository navigation
chore(deps): bump knip to 6.44.1 - #9896
Merged
Merged
Conversation
knip 6.44.1 tracks member use inside import().then() callbacks and follows Tailwind @reference and bun spawn arguments, so check:unused-exports now sees: - six exports only used in their own file (previously kept alive by an import('...').then(...) of their module): drop the export keyword and the matching keys in the storage-service test mock and the shared telemetry mock - @sim/auth-ui's stylesheet uses @reference/@apply from tailwindcss without listing it: declare it as a peer dependency (consumers compile it) - packages/db integration tests spawn bun scripts with an explicit cwd that knip cannot see: ignore those three specifiers with a reason
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
 [Medium impact] This PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "chore(deps): bump knip to 6.44.1" · Reviewed by Greptile |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knip6.41.0 → 6.44.1 (root devDependency). Lockfile moves only knip's own transitives (oxc-parser0.153 → 0.155,unbash5 → 6).import().then()callbacks (6.44.1), follows Tailwind@reference(6.43.0), and parses bun's command after boolean flags (6.44.1).check:unused-exports(the only knip consumer) surfaced 10 new findings, all resolved at the source:NOTE_EDITOR_PROSE_CLASS_NAME,createOTelSpanFromTraceSpan,trackPlatformEvent,parseGcsCredentials,getS3Client, and theSetRequestAuthOptionsre-export from@sim/logger. Each one is used only in its own file; 6.41.0 counted them as used because some other caller doesimport('<module>').then(...), which marked every export of that module as used. Dropped theexportkeyword (and the logger re-export), plus the matching keys in thestorage-service.test.tsS3 mock and the sharedtelemetryMock(no test read them). Also fixed a stale comment that pointed at a parity test removed in chore(tests): remove low-signal tests and consolidate the testing setup #8295.@sim/auth-ui'sstyles.module.cssuses@reference 'tailwindcss'and@apply, but the package didn't listtailwindcss. Its consumers compile it (apps/sim, and desktop through apps/sim's PostCSS config), so it's now declared as apeerDependency(^4), next toreact.packages/dbintegration tests spawnbun --no-env-file scripts/…with an explicitcwd(the package root, or apps/sim forbackfill-projects.ts), and knip resolves those paths from the test file's own directory. I added these 3 specifiers to theignoreUnresolvedlist for that workspace inknip.jsonc, with a comment giving the reason.scripts/check-unused-exports.baseline.jsonis unchanged.Type of Change
Testing
bun run check:unused-exportson 6.41.0 (baseline): passes, 5975 baselined. On 6.44.1 before the fixes: 4 strict + 6 new export findings (listed above). After the fixes: passes, 5975 baselined, no stale entries.bun install --frozen-lockfileclean.@sim/logger,@sim/testing, and@sim/auth-ui: clean.lib/uploads/core/storage-service.test.ts+lib/uploads/providers(74 passed), and two telemetry-mock consumers (knowledge/migrated-routes, v2 knowledge documents route; 17 passed).check:test-patternspasses. Biome is clean on the changed files.Checklist
🤖 Generated with Claude Code