Repository navigation
chore(deps): bump electron-builder to 26.18.0 - #9893
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] This dependency upgrade appears safe to merge. SummaryUpdates the desktop build dependency
Reviews (1) · Last reviewed commit: "chore(deps): bump electron-builder to 26..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electron-builder26.15.3 → 26.18.0 inapps/desktop(devDependency). Lockfile moves only the builder family (app-builder-lib/dmg-builder/electron-publish/electron-builder-squirrel-windows26.18.0,builder-util26.16.0,@electron/rebuild4.2.1, plus a nested@noble/hashes@1forapp-builder-lib).electron-updateris versioned independently and already on its latest 6.x (6.8.12), so it is not part of this bump.publish: githubused only forapp-update.yml):app.asaris byte-identical before and after (below).-snlagain instead of the nativezip -ypath that 26.15.x used; symlinks are preserved and the extracted app passescodesign --verify --deep --strict(below).LICENSE.electron.txtandLICENSES.chromium.htmlare now retained inContents/Resources(license compliance; two new files in the bundle, outside the asar).set-key-partition-listnow gets the temp keychain password. Only used when electron-builder importsCSC_LINKitself; our release workflow prepares its own keychain and passesCSC_KEYCHAIN, so that path is not taken.store-asar).dmg-builderand the GitHub publisher have no code changes. The rest (NSIS, snap, flatpak, pnpm, squirrel, gitlab, MASafterSign) doesn't apply to our targets.Type of Change
Testing
Unsigned local packages on 26.15.3 and 26.18.0 from the same
dist/(CSC_IDENTITY_AUTO_DISCOVERY=false,--publish never, ad-hoc identity, hardened runtime off, arm64; the icon was swapped for a PNG because this machine has no Xcode 26actool, identical for both runs):--mac dir:app.asaris byte-identical (cmp), and so isapp.asar.unpacked. Its file list (3,633 entries) has the expected production deps (@sim/*workspace packages,electron-updater,@lydell/node-pty+ both darwin prebuilds, etc.), no devDependencies, and the../simfont mapping still lands atstatic/SeasonSansUprightsVF.woff2.Info.plistis identical. The only bundle difference is the two license files above.--mac zip: extracted withditto -x -k(how Squirrel.Mac unpacks updates). Both versions keep all 14 symlinks with identical targets, every*.framework/Versions/Currentis a symlink,codesign --verify --deep --strictpasses, the embeddedapp.asarandapp-update.ymlare identical, andlatest-mac.ymlhas the same shape.desktop-e2e / package-smokebuilds the universal unsigned app and runs the packaged smoke suite on this PR.Only a signed release run can confirm these: Developer ID signing + notarization of the universal dmg/zip, and the
.icon→ Assets.car/icns path with the newer icons toolset (needs Xcode 26).Checklist
🤖 Generated with Claude Code