Repository navigation
chore(deps): upgrade monaco-editor to 0.57.0 - #9892
Merged
Merged
Conversation
0.56 reorganized the package exports so subpaths map under esm/vs; the old monaco-editor/esm/vs/... worker URLs no longer resolve. Point the file editor's workers at the new supported entry points.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 [Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryUpgrades
Reviews (1) · Last reviewed commit: "chore(deps): upgrade monaco-editor to 0...." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monaco-editor0.55.1 → 0.57.0.@monaco-editor/reactstays on 4.7.0: it's the latest stable release and its peer range is>= 0.25.0 < 1.exports."./*"now maps to./esm/vs/*.js, so the oldmonaco-editor/esm/vs/language/<lang>/<lang>.workerandmonaco-editor/esm/vs/editor/editor.workerspecifiers resolve toesm/vs/esm/vs/..., which doesn't exist. The file editor'sMonacoEnvironment.getWorkernow uses the supported entry pointsmonaco-editor/languages/features/<lang>/<lang>.workerandmonaco-editor/editor/editor.worker.stackOridinal→stackOrdinal, removingIMirrorModel/IWorkerContext) don't affect Sim. Sim doesn't uselanguages.typescript/jsondefaults.MonacoEnvironment.getWorkerstill takes priority over the built-in worker factory (internal/common/workers.js). The rootimport('monaco-editor')still exportseditor,KeyMod, andKeyCode, and the editor CSS is still imported through the same side-effect imports. 0.57 is additive (new options, DOMPurify bump, which the rootdompurifyoverride already covers).Type of Change
Testing
apps/sim) against 0.57.0: the oldesm/vs/language/json/json.workerandesm/vs/editor/editor.workerspecifiers fail with "Could not resolve". All five new worker specifiers andmonaco-editorbundle.monaco-editor0.57.0 with agetWorkerthat has the same label→worker routing astext-editor.tsx, using the new specifiers, and created editors. The JSON worker reported "Trailing comma", CSS reported "Unknown property", the TS worker reported a type error, and the diff editor got its line changes from the editor worker. There were no page or console errors.tsc --noEmitscoped totext-editor.tsx(+ app ambient types): clean.bun install --frozen-lockfile: clean. The lockfile only changed formonaco-editor.next buildlocally, so CI covers the Turbopack bundle. Reviewers: please open a code/JSON file in the Files editor on the preview and check that syntax validation and the find widget work.Checklist
🤖 Generated with Claude Code