Repository navigation
chore(deps): upgrade cronstrue to 3.38.0 - #9891
Merged
Merged
Conversation
Use cronstrue's trimHoursLeadingZero option instead of a regex over its output, and update the schedule description tests to the new English wording.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryUpgrades
No actionable issues found. Tests were not run; installed dependencies were unavailable. Reviews (1) · Last reviewed commit: "chore(deps): upgrade cronstrue to 3.38.0" · Reviewed by Greptile |
This was referenced Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cronstrue3.3.0 → 3.38.0 (apps/sim only; no transitive deps, lockfile changes only this package).parseCronToHumanReadable, which renders the schedule description in the Schedule block's schedule info.trimHoursLeadingZerooption, so the regex that stripped the hour's leading zero from cronstrue's output (09:00 AM→9:00 AM) is replaced by the option. Output is identical: checked against every hour × several minutes plus ranges, lists, and nth-weekday expressions (105 expressions, 0 differences).1 * * * *"At 1 minutes past the hour" → "At 1 minute past the hour"0 */2 * * *"At 0 minutes past the hour, every 2 hours" → "On the hour, every 2 hours"0 0 */2 * *"every 2 days" → "every 2 days in a month"#0/#6nth weekdays) now throws in cronstrue. Every newly throwing expression is already rejected by croner, sovalidateCronExpressionrefuses it before a schedule is saved; if one is already stored, the existing fallback showsSchedule: <expr>instead of misleading text like "on the null Monday" or "January through undefined". No change to Sim's validation needed.Type of Change
Testing
L,W,#n,#L, macros, 6-field). The only differences are the wording changes above and the newly throwing expressions, all of which croner already rejects.parseCronToHumanReadablefrom the branch with and without a timezone. The new wording, the#Lnormalization, the timezone suffix, and theSchedule: <expr>fallback all work.utils.test.ts: the description tests now use exact strings (they were mostlytoContain) and cover the singular-unit and step wording. WithouttrimHoursLeadingZerothe builder test fails (At 09:00 AM).lib/workflows/schedules/tests: 58 passed.Checklist
🤖 Generated with Claude Code