Skip to content

feat(table): add Columns to Return to the legacy Table block's Query Rows - #9887

Merged
waleedlatif1 merged 3 commits into
stagingfrom
feat/table-query-columns-sim34
Nov 11, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
feat/table-query-columns-sim34

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The legacy Table block (table, superseded by table_v2) now has the same Columns to Return picker as table_v2. Existing workflows still run on the legacy block, and the upgrade is a Copilot-assisted rewrite rather than an automatic one.
  • A query that leaves it empty behaves exactly as before. With columns selected, each returned row's data keeps only those columns, so large cells a workflow never reads no longer land in its execution data or count against the 5 MiB row-data budget.
  • Wiring only, reusing the existing projection in queryTableRows:
    • table_query_rows takes an optional columns param, sent as a JSON query value.
    • The internal listTableRowsContract accepts columns, and both the GET rows route and executeTableQueryRows pass it through. The shared tableRowsQueryBaseSchema that the public v1/v2 APIs extend is unchanged.
    • The column-reference schema is extracted and shared with the v2 query body contract.
  • The "Columns to Return" field, its input, and the parser (canvas selection first, a model-supplied columns as the fallback, fail fast on malformed values) now live in blocks/utils.ts, shared by both Table blocks. A malformed-JSON error now reads "Invalid JSON for Columns to Return" (was "in"), from the shared parseOptionalJsonInput.

Type of Change

  • New feature (backward compatible)

Testing

  • New tests, each shown red by reverting its part of the change (contract field, tool serialization, block mapping):
    • execute-tool.test.ts runs the real v1 tool serialization through the real contract decoding into the operation.
    • A legacy block transformer case in table.test.ts.
  • Ran execute-tool.test.ts, table.test.ts, table_v2.test.ts, operations.test.ts, the rows route.test.ts, query_rows_v2.test.ts and blocks/utils.test.ts: 55 passed.
  • Ran bun run lint, check-block-registry.ts origin/staging, check:api-validation:strict, check:explicit-any, check:client-boundary, check:tool-registry-boundary, check:utils and check:comment-hygiene. generate:tool-metadata was regenerated.
  • bun run type-check (pre-push hook) passes; check:audits and the full test suite are left to CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 8:29pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; stale selections no longer return excluded fields.

Summary

Adds Columns to Return to the legacy Table block’s Query Rows operation.

  • Legacy Table queries can return only the columns you choose.

No new actionable issues were found in the changes since the previous review. Tests were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Legacy Table picker] --> B[Shared selection parser]
  B --> C[table_query_rows]
  C --> D[Internal query contract]
  D --> E[queryTableRows]
  E --> F[Rows with selected data]
Loading

Reviews (3) · Last reviewed commit: "Revert "fix(table): treat a column selec..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/api/contracts/tables.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/table/application/rows.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 77ae0957 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant