Repository navigation
feat(table): add Columns to Return to the legacy Table block's Query Rows - #9887
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; stale selections no longer return excluded fields. SummaryAdds Columns to Return to the legacy Table block’s Query Rows operation.
No new actionable issues were found in the changes since the previous review. Tests were not run during this review.
|
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…ns as all columns" This reverts commit 1b59b12.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
table, superseded bytable_v2) now has the same Columns to Return picker astable_v2. Existing workflows still run on the legacy block, and the upgrade is a Copilot-assisted rewrite rather than an automatic one.datakeeps only those columns, so large cells a workflow never reads no longer land in its execution data or count against the 5 MiB row-data budget.queryTableRows:table_query_rowstakes an optionalcolumnsparam, sent as a JSON query value.listTableRowsContractacceptscolumns, and both the GET rows route andexecuteTableQueryRowspass it through. The sharedtableRowsQueryBaseSchemathat the public v1/v2 APIs extend is unchanged.columnsas the fallback, fail fast on malformed values) now live inblocks/utils.ts, shared by both Table blocks. A malformed-JSON error now reads "Invalid JSON for Columns to Return" (was "in"), from the sharedparseOptionalJsonInput.Type of Change
Testing
execute-tool.test.tsruns the real v1 tool serialization through the real contract decoding into the operation.table.test.ts.execute-tool.test.ts,table.test.ts,table_v2.test.ts,operations.test.ts, the rowsroute.test.ts,query_rows_v2.test.tsandblocks/utils.test.ts: 55 passed.bun run lint,check-block-registry.ts origin/staging,check:api-validation:strict,check:explicit-any,check:client-boundary,check:tool-registry-boundary,check:utilsandcheck:comment-hygiene.generate:tool-metadatawas regenerated.bun run type-check(pre-push hook) passes;check:auditsand the full test suite are left to CI.Checklist
test-auditauthoring gate)