Skip to content

fix(tables): show rejected filter errors in the grid and fill imports to the row limit - #9881

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/table-filter-error-import-row-limit
Nov 11, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/table-filter-error-import-row-limit

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Table grid now shows the rows-query error instead of an empty table. A filter the server rejects (e.g. 1,000 on a number column with a range operator) used to look identical to "no rows match", because useTable never read the query's error. Only a failed first page shows it; a failed next page or background refetch keeps the loaded rows
  • Streaming CSV import now fills the table up to the plan row limit instead of rejecting the whole batch that crosses it. Batches are 5,000 rows, so a file one row over the limit stopped ~4,900 rows short while the error said the table had reached its limit
  • When the import stops at the limit, the job fails with how many rows landed (Import stopped at this table's row limit (N rows) on your current plan. M rows were imported; the rest of the file was not.) and persists that count as progress. Appending to a table that is already full still fails with the existing row-limit error and inserts nothing
  • No change to the no-rollback design, the sync import path, or TableRowLimitError's wording

Type of Change

  • Bug fix

Testing

  • lib/table/import-runner.test.ts: 5 new row-limit cases (crossing batch fills to the limit, batch landing exactly on the limit with rows left, append counts existing rows, already-full table inserts nothing, file that exactly fills completes). 4 of them fail against the pre-fix runner, and reverting each new guard (partial-batch slice, imported-count error, progress write before the stop) turns at least one test red
  • hooks/use-table.test.ts passes
  • biome check on changed files; full type-check, audits and suite left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 6:33pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both earlier findings are fixed and no new actionable issues were found.

Summary

The PR shows rejected row-query errors in the grid and lets streaming CSV imports fill the table to its plan limit.

  • Table grids now show why the first rows page failed.
  • CSV imports now use the remaining room under a table’s row limit.

Reviews (2) · Last reviewed commit: "fix(tables): use caption size for the gr..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d43f163 into staging Nov 11, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/table-filter-error-import-row-limit branch November 11, 2026 19:46

This branch was previously deployed

1 inactive deployment
Preview — 5ff8eca7 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant