chore(db): drop retired usage columns and compatibility scaffolding by icecrasher321 · Pull Request #7868 · simstudioai/sim

icecrasher321 · 2026-09-15T23:36:44Z

Summary

Drop the 19 retired user_stats columns, organization.departed_member_usage, workflow_execution_logs.cost, and workspace_files.size, completing the prep in improvement(db): stop declaring retired usage columns ahead of their drop #7134, fix(db): exclude pending-drop columns from inserts #7774, and fix(auth): exclude retired organization columns from adapter queries #7813.
Remove the temporary column projections, insert wrapper, Better Auth schema override, size-sync trigger/function, completed backfills, and dev cutover runner. Update callers and mocks to use the final schema.
Preserve intentionally destructive local/dev db:push behavior and forward CLI flags such as --force to Drizzle before reconciliation. Staging and production continue to use versioned migrations.
Keep the drop replay-safe and reject populated installations that skipped the required v0.8.38 backfills. Preserve the general pending-drop audit and add isolated PostgreSQL migration coverage to both database-provisioning CI jobs.

Type of Change

Maintenance / database cleanup

Testing

App and database type checks, lint, all 46 repository audits (including API validation), migration safety, and schema-generation consistency passed.
1,519 automated tests passed across affected application suites, database suites, script suites, and the new contract-migration tests.
PostgreSQL 17: full migration history and no-op replay; skipped-backfill rejection; canonical value preservation; released prep code's inserts and RETURNING after the actual drop; fresh and populated forced schema pushes.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-15T23:36:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 16, 2026 12:15am UTC

greptile-apps · 2026-09-15T23:40:31Z

Confidence Score: 5/5

The PR appears safe to merge with no outstanding blocking findings.

Summary

This PR completes the retired database-column cleanup and removes the compatibility code that supported the transition.

Drops retired usage, execution-cost, and workspace-file-size columns through a guarded, replay-safe migration.
Updates application reads and writes to use the final Drizzle schema directly.
Removes completed backfills, projections, wrappers, triggers, and development cutover scaffolding.
Preserves direct development schema reconciliation while keeping staging and production on versioned migrations.
Adds PostgreSQL migration coverage and updates attachment-provenance behavior introduced since the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Database deployment] --> B{Environment}
    B -->|Development| C[db:push --force]
    C --> D[Drizzle direct schema reconciliation]
    D --> E[Post-push reconciliation scripts]
    B -->|Staging or production| F[db:migrate]
    F --> G[Migration 0348 receipt and backfill checks]
    G --> H[Drop retired columns]
    H --> I[Final application schema]
    E --> I

_{Reviews (3) · Last reviewed commit: "fix(db): forward force flags for local a..."}

cubic-dev-ai

All reported issues were addressed across 58 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

icecrasher321 · 2026-09-16T00:05:42Z

@greptile

icecrasher321 · 2026-09-16T00:05:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T00:05:49Z

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 61 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

icecrasher321 · 2026-09-16T00:13:44Z

@greptile

icecrasher321 · 2026-09-16T00:13:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-16T00:13:53Z

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 61 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

icecrasher321 requested a review from a team as a code owner September 15, 2026 23:36

vercel Bot deployed to Preview September 15, 2026 23:38 View deployment

greptile-apps Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread .github/workflows/migrations.yml

waleedlatif1 mentioned this pull request Sep 15, 2026

v0.8.39: search and file handling fixes, organization settings, bounded cleanup #7864

Merged

cubic-dev-ai Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread .github/workflows/migrations.yml

icecrasher321 force-pushed the codex/drop-retired-stats-columns branch from 4e68075 to c394c17 Compare September 16, 2026 00:05

vercel Bot deployed to Preview September 16, 2026 00:08 View deployment

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

icecrasher321 added 2 commits September 15, 2026 17:12

chore(db): drop retired usage columns and compatibility scaffolding

ae54aeb

fix(db): forward force flags for local and dev schema pushes

5a255fe

icecrasher321 force-pushed the codex/drop-retired-stats-columns branch from c394c17 to 5a255fe Compare September 16, 2026 00:13

vercel Bot deployed to Preview September 16, 2026 00:15 View deployment

cubic-dev-ai Bot reviewed Sep 16, 2026

View reviewed changes

icecrasher321 merged commit 783cf17 into staging Sep 16, 2026
34 checks passed

icecrasher321 deleted the codex/drop-retired-stats-columns branch September 16, 2026 00:25

waleedlatif1 mentioned this pull request Sep 16, 2026

v0.8.40: browser agent improvements, permission requests #7876

Open

Navigation Menu

Uh oh!

chore(db): drop retired usage columns and compatibility scaffolding - #7868

chore(db): drop retired usage columns and compatibility scaffolding#7868
icecrasher321 merged 2 commits into
stagingfrom
codex/drop-retired-stats-columns

icecrasher321 commented Sep 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Sep 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

icecrasher321 commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

icecrasher321 commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 16, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

icecrasher321 commented Sep 15, 2026 •

edited

Loading

vercel Bot commented Sep 15, 2026 •

edited

Loading

greptile-apps Bot commented Sep 15, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading