Skip to content

fix(landing): stabilize announcement scrolling and mobile previews - #7852

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/landing-announcement-scroll
Sep 15, 2026
Merged

fix(landing): stabilize announcement scrolling and mobile previews#7852
waleedlatif1 merged 1 commit into
stagingfrom
codex/landing-announcement-scroll

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Hide the landing announcement on downward scroll and restore it on upward scroll, keeping navigation and menu positions stable.
  • Scale landing previews uniformly so mobile Safari text stays inside its rows.
  • Fit the static reduced-motion workflow inside narrow screens.

Type of Change

  • Bug fix

Testing

  • 211 landing tests passed, including scroll direction, jitter, overscroll, focus, menu locking, cleanup, and preview scaling.
  • Responsive QA in Chromium and WebKit at phone, iPad, and desktop sizes; additional 320px and iPad landscape checks, feature cards, and footer review.
  • Type-check, lint, all 46 repository audits (including API validation), block registry validation, and generated-artifact checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 4:52am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no concrete correctness, accessibility, security, or repository-rule failure identified.

Summary

This PR stabilizes the landing-page announcement header and improves narrow-screen preview rendering.

  • Hides and restores the announcement according to accumulated scroll direction while preserving header and menu positioning.
  • Moves responsive design previews from CSS zoom to uniform transform scaling for mobile Safari.
  • Allows the complete reduced-motion workflow overview to fit narrow viewports.
  • Adds coverage for scrolling, focus, overscroll, menu locking, cleanup, and transform scaling.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Scroll[Landing scroll event] --> Clamp[Clamp scroll position]
  Clamp --> Top{Near announcement height?}
  Top -->|Yes| Show[Show announcement]
  Top -->|No| Menu{Menu open?}
  Menu -->|Yes| Hold[Keep header state stationary]
  Menu -->|No| Threshold{Direction delta meets threshold?}
  Threshold -->|No| Accumulate[Retain baseline and accumulate movement]
  Threshold -->|Yes, downward| Hide[Hide announcement and reduce visible header offset]
  Threshold -->|Yes, upward| Show
  Resize[Preview host resize] --> Scale[Calculate width/height limiting scale]
  Scale --> Transform[Apply uniform transform scale]
  Reduced[Reduced-motion workflow] --> Fit[Fit complete graph with reduced minimum zoom]
Loading

Reviews (1) · Last reviewed commit: "fix(landing): stabilize announcement scr..."

@waleedlatif1
waleedlatif1 merged commit e21130b into staging Sep 15, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/landing-announcement-scroll branch September 15, 2026 04:57
@waleedlatif1 waleedlatif1 mentioned this pull request Sep 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1