fix(executor): seed run-wide access key lists and scope exact-key cache grants - #7850
Merged
Merged
Conversation
…he grants - Seed largeValueKeys/fileKeys in createExecutionContext so keys a block records on its per-block context copy reach later blocks; child executors get their own lists, never the parent's - Share one exact-key grant predicate between the async storage check and the sync large-value cache, which previously honored a granted key without checking the key's workspace and workflow - Correct the executionFilesById TSDoc: the index is built per block from block states
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
largeValueKeys/fileKeyslists, so the??= []append a block makes landed on its per-block context copy and was dropped. Seed both lists increateExecutionContext: top-level runs keep the lists they pass in, child executors get their own empty lists and never the parent's (an exact key is an access grant, so sharing would widen access across custom blocks)isGrantedLargeValueKeypredicateexecutionFilesByIdTSDoc: the index is built per block from block states, not shared across the runType of Change
Testing
Checklist